From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49F92C433EF for ; Sun, 20 Feb 2022 13:20:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE3B1832DB; Sun, 20 Feb 2022 14:20:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qhQA9pW7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60E038366A; Sun, 20 Feb 2022 14:20:20 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C1B228169D for ; Sun, 20 Feb 2022 14:20:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id e22so25255281qvf.9 for ; Sun, 20 Feb 2022 05:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d0faLhpkUyEoDy6Cedr6kHJ32YOJ1oFF/TZuaHRYpWU=; b=qhQA9pW7SGpIIbVcLcL5757iKkwG1h6sbUX/5uQQ4Jl9OhbVfNi04rAGBrU1VUrpi6 vB/oRubpcqwxUKJZnK9F8Rn66cmb/LaCBPT1UcoOYMXdH2ms6WfS9p2MDe229WrO4FLf khSA7B6z0f0wF66YnnZKiH4kjuCbGmYdmAwcM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d0faLhpkUyEoDy6Cedr6kHJ32YOJ1oFF/TZuaHRYpWU=; b=fo0RWiD5ifBH0OTGewkzRDBACq0DNWpdUPvwPCUIonLngnI9/mu4TINsJqOcFYfD/n WqOeDwFMQrRzJGMi/wx0LWIB9s2GmO/PzuAdyKolNM7MM9KfQAFIfTPSeKdr0okqe6C8 ld8oSSVtdCXVXunFZzzdLmU3ovrzfzwLrEIxqvHfOm6MCCEiRkiMO1pCfkfgu7xZF7TY s/kNbMlkiMvqEhrJ/zJst6qXJJ2WgGdgXYckrDLbNZYg9OUnbhvmSRWydpu1o+P/QmKr V142q2RrGQWDEJNZndQGgiZMBUOgy7gvg/i5Ec5dCQsvJEiqSse7ebbmg+nZHCIHrZS1 Frmw== X-Gm-Message-State: AOAM533Q2b1iKlIDcyN5roThshzuxyH7ZGfcXPO82kN5B3BWtxFVfDNH 1BGSyntf9xyWl5AhpKlTUOaZyg== X-Google-Smtp-Source: ABdhPJyx98oQN6tpTLuhZ3g6/r7mcTSiKM7062yM2rYo/t/RgJEolSm1ogBs4+PsemHn77JazG0dFw== X-Received: by 2002:a05:6214:21ae:b0:42b:e96b:38b2 with SMTP id t14-20020a05621421ae00b0042be96b38b2mr12226031qvc.14.1645363215406; Sun, 20 Feb 2022 05:20:15 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id r15sm2736623qtw.70.2022.02.20.05.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 05:20:14 -0800 (PST) Date: Sun, 20 Feb 2022 08:20:12 -0500 From: Tom Rini To: Linus Walleij Cc: u-boot@lists.denx.de, Markuss Broks , Stephan Gerhold Subject: Re: [PATCH] board: stemmy: Detect board variants and patch DTB Message-ID: <20220220132012.GF1576803@bill-the-cat> References: <20220220010942.1634904-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WbqItKNU/G8FVTDf" Content-Disposition: inline In-Reply-To: <20220220010942.1634904-1-linus.walleij@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --WbqItKNU/G8FVTDf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 20, 2022 at 02:09:42AM +0100, Linus Walleij wrote: > This patch scans the cmdline from the Samsung SBL (second stage > bootloader) and stores the parameters board_id=3DN and lcdtype=3DN > in order to augment the DTB for different board and LCD types. >=20 > We then add a custom command "stemmy_patch" that will inspect > the DTB and patch it using the stored LCD type. At this point > we know which product we are dealing with, so using the passed > board_id we can also print the board variant for diagnostics. >=20 > We patch the Codina, Skomer and Kyle DTBs to use the right > LCD type as passed in lcdtype from the SBL. >=20 > This also creates an infrastructure for handling any other > Samsung U8500 board variants that may need a slightly augmented > DTB. >=20 > Cc: Markuss Broks > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij > --- > This patch depends on the patch to abootimg.c that makes the > abootimg command properly report the location of a DTB in the > "second" area submitted earlier. >=20 > The patch refers to samsung,codina-tmo which is a device tree > which is not yet in the upstream Linux kernel but it is on > its way there. My only real question / concern is why is this a command and not board_fixup_fdt() ? --=20 Tom --WbqItKNU/G8FVTDf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmISQAUACgkQFHw5/5Y0 tyxKwgv7BOaplrX0vM+OD5eRKHtd3bWwc6Cq+VBYlEbo18ADzkCMPLVju5TZt+tO sT5BMTOAh2G8RH6HLyPMvhFu0URLfUwaDt2XAJi1AH3mLRvIFbpvzPCTmzaL49TZ q0T7ynTwxBKDUefi+eTUjU22raAXUeOUOmQg04tYfoPd5CtRm5Og/5gU7jwGAu3l RXmsKxsjEUq/ZnrKETHY2FVZ/sfxFWpHnOyCMw1eyhh1IBTy0bKhm3ciUoih4x9u IM+jRtOp9cm0Zy9bZ4MZ4rDa4RlKLfxm5F8Ce0assCgFQLrSz0HQtwqieLKJ7c1z 5o0n4vvJSr2OU6f8IqxSY2ycio4B9ByOljV/pnTGuJLLu3vaeGGFuTaLHpagoN60 UdUxAwr6fHEgWGjuHpmjPiuy/9hfT/nAho/s1E7gNMeWoggz9SzZS5rl+3j1+tmH 9ixhsJVxtfU9KJcBIMkysneOuRHzDL6LFMjWAj0JkM0rg3sxbteBXCPzsuFKU29m TkjsEUO9 =tw5q -----END PGP SIGNATURE----- --WbqItKNU/G8FVTDf--