Re: [PATCH v1 03/11] spi: rockchip-sfc: fix building rockchip-sfc

Peter Geis
2022-03-14T11:36:53Z

On Mon, Mar 14, 2022 at 4:47 AM Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Peter,

Good Morning,

>
> On 2022/2/22 09:31, Peter Geis wrote:
> > The rockchip-sfc driver is missing an include to build correctly.
>
>
> I think this driver builds OK and has been tested by other developer,
> could you share what kind of build environment do you using and what
> issue did you meet?

If you enable debugging, the dev_dbg functions are not included due to
header cleanups.
dm/device_compat.h provides them.

>
>
> Thanks,
>
> - Kever

Always,
Peter

>
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> > drivers/spi/rockchip_sfc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c
> > index e098addddcac..851a6482985b 100644
> > --- a/drivers/spi/rockchip_sfc.c
> > +++ b/drivers/spi/rockchip_sfc.c
> > @@ -12,6 +12,7 @@
> > #include <bouncebuf.h>
> > #include <clk.h>
> > #include <dm.h>
> > +#include <dm/device_compat.h>
> > #include <linux/bitops.h>
> > #include <linux/delay.h>
> > #include <linux/iopoll.h>