From: Peter Geis <pgwipeout@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Peter Geis <pgwipeout@gmail.com>, u-boot@lists.denx.de
Subject: [PATCH v1 04/11] spi: rockchip-sfc: sanity check minimum freq
Date: Mon, 21 Feb 2022 20:31:23 -0500 [thread overview]
Message-ID: <20220222013131.3114990-5-pgwipeout@gmail.com> (raw)
In-Reply-To: <20220222013131.3114990-1-pgwipeout@gmail.com>
The rockchip-sfc driver sanity checks the maximum frequency, but not the
minimum frequency.
This causes the probe to fail when a frequency isn't defined, such as
with `sf probe 0`.
Clamp the minimum frequency to the rockchip default clock rate.
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
drivers/spi/rockchip_sfc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c
index 851a6482985b..d0d2dc70a417 100644
--- a/drivers/spi/rockchip_sfc.c
+++ b/drivers/spi/rockchip_sfc.c
@@ -164,6 +164,8 @@
/* DMA is only enabled for large data transmission */
#define SFC_DMA_TRANS_THRETHOLD (0x40)
+#define SFC_MIN_SPEED (24 * 1000 * 1000)
+
/* Maximum clock values from datasheet suggest keeping clock value under
* 150MHz. No minimum or average value is suggested.
*/
@@ -596,6 +598,9 @@ static int rockchip_sfc_set_speed(struct udevice *bus, uint speed)
if (speed > sfc->max_freq)
speed = sfc->max_freq;
+ if (speed < SFC_MIN_SPEED)
+ speed = SFC_MIN_SPEED;
+
if (speed == sfc->speed)
return 0;
--
2.25.1
next prev parent reply other threads:[~2022-02-22 1:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 1:31 [PATCH v1 00/11] rockchip fixes and extend rk3568 support Peter Geis
2022-02-22 1:31 ` [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-12 3:32 ` Peter Geis
2022-03-12 5:02 ` Simon Glass
2022-03-14 8:51 ` Kever Yang
2023-01-04 18:30 ` Jagan Teki
2022-02-22 1:31 ` [PATCH v1 02/11] mmc: sdhci: allow disabling sdma in spl Peter Geis
2022-02-25 1:46 ` Jaehoon Chung
2022-03-14 8:41 ` Kever Yang
2022-02-22 1:31 ` [PATCH v1 03/11] spi: rockchip-sfc: fix building rockchip-sfc Peter Geis
2022-03-14 8:45 ` Kever Yang
2022-03-14 11:36 ` Peter Geis
2022-02-22 1:31 ` Peter Geis [this message]
2022-03-14 8:53 ` [PATCH v1 04/11] spi: rockchip-sfc: sanity check minimum freq Kever Yang
2022-03-15 2:10 ` Jon Lin
2022-02-22 1:31 ` [PATCH v1 05/11] spl: support adc drivers in spl Peter Geis
2022-02-22 1:31 ` [PATCH v1 06/11] rockchip: handle bootrom recovery mode " Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-12 3:37 ` Peter Geis
2022-03-14 9:08 ` Kever Yang
2022-03-14 11:51 ` Peter Geis
2022-03-14 11:59 ` Philipp Tomsich
2022-03-14 12:34 ` Peter Geis
2022-02-22 1:31 ` [PATCH v1 07/11] rockchip: rk3568: add boot device detection Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-12 3:34 ` Peter Geis
2022-02-22 1:31 ` [PATCH v1 08/11] rockchip: rk3568: enable automatic clock gating Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-14 8:52 ` Kever Yang
2022-02-22 1:31 ` [PATCH v1 09/11] rockchip: move dwc3 config to chip specific handler Peter Geis
2022-03-12 2:24 ` Simon Glass
2023-02-27 7:10 ` Jagan Teki
2022-02-22 1:31 ` [PATCH v1 10/11] rockchip: rk3568: add dwc3 otg support Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-12 3:38 ` Peter Geis
2022-02-22 1:31 ` [PATCH v1 11/11] [RFC] rockchip: rk356x: attempt to fix ram detection Peter Geis
2022-03-12 2:24 ` Simon Glass
2022-03-12 3:54 ` Peter Geis
2022-03-12 5:02 ` Simon Glass
2022-03-12 14:46 ` [PATCH v1 00/11] rockchip fixes and extend rk3568 support Kever Yang
2022-03-14 8:56 ` Kever Yang
2022-03-14 11:42 ` Peter Geis
2022-03-14 9:06 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222013131.3114990-5-pgwipeout@gmail.com \
--to=pgwipeout@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox