From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF0E8C433F5 for ; Tue, 22 Feb 2022 01:32:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B2FEF83C9C; Tue, 22 Feb 2022 02:32:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RmS0OgqN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ABF8583C3C; Tue, 22 Feb 2022 02:31:51 +0100 (CET) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACD4D83C7E for ; Tue, 22 Feb 2022 02:31:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pgwipeout@gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id f19so36944489qvb.6 for ; Mon, 21 Feb 2022 17:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9uXOoYNLD6irtNbGgSuxDeZ/T20yCJSAtixcUZ5gEd4=; b=RmS0OgqNz5VOm4UMvay/WwVjWyQRKD4ZCyx8CE9IcrBUwJEMtfl1x633AU6w2/H0St hFkvQ14eqD8djB98z1HzFruvT1XrTt1w4I8xGPiOyb/uOgo29LHoxKckG2TLuQReBont o01m3rzHiggc54gfdgeQGBDeGHkiUXidz5XVP+eMY4L5OPvw+JPfmCyaIA3cM22nVO/M znnLti+Dy17xxQmm0lqYEt0e9WltUN5OO83Sq9WfeZyWfMXb3uLzvhIgF+2TNwPjJ/gK DEGuIJU60mCbLahgfpi4zjLVaJMK4cx8ZW6Sh/JSmJ2kmi+6tR1cO4So/lWtRxUynqhb ENVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9uXOoYNLD6irtNbGgSuxDeZ/T20yCJSAtixcUZ5gEd4=; b=prMJhg+VcqZ70mGkdMdQQ1+hLF29scokGCGTCnMeElgZrzWBKiPAzf6OoS9BkzUrye pZUxdwPgqzk2g32BybTIqvKxfSl7B9xOLPxWg2i9LPJgUh4XgomlL9dmN5nuMiaLjowX SAjtwEa6b4VhPYb2CcU5m3CZDLBvV3qYJUHtTTW805xe3av5n3Itc87MbHxcePQirGf9 E/R9BZiwQJTH9poDN4Z67DXT7Atx/KowYqo0pWJBt9oqtIYLwlOhp7J2KNvwPEsl1xu+ FqnXUcoMOx0V6lp52O6EXZK7ItPYatvGnbdzkBqRw3AmujVysPFbhaHlc8Nf2NIjCRFM gopw== X-Gm-Message-State: AOAM530lIzkGzsRXvGzKJpKHMsJ+i3/UDG2HMiy6JJRGQyMCN8ykTquw 0zS7XswMXNHkquM2D4a0Q9inBGZi0Tc= X-Google-Smtp-Source: ABdhPJwa+lNPcalIOm+6oAmGfJxujmAmXaeVPPpe6aFOSL9e8ebrIXYqo4Qqz76ya3rbnU/P7qmeSg== X-Received: by 2002:a0c:fc09:0:b0:42c:42f:6ba2 with SMTP id z9-20020a0cfc09000000b0042c042f6ba2mr17653222qvo.35.1645493496454; Mon, 21 Feb 2022 17:31:36 -0800 (PST) Received: from master-x64.sparksnet (c-98-233-193-225.hsd1.dc.comcast.net. [98.233.193.225]) by smtp.gmail.com with ESMTPSA id q12sm31597841qtx.51.2022.02.21.17.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 17:31:36 -0800 (PST) From: Peter Geis To: Jagan Teki Cc: Peter Geis , u-boot@lists.denx.de Subject: [PATCH v1 04/11] spi: rockchip-sfc: sanity check minimum freq Date: Mon, 21 Feb 2022 20:31:23 -0500 Message-Id: <20220222013131.3114990-5-pgwipeout@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222013131.3114990-1-pgwipeout@gmail.com> References: <20220222013131.3114990-1-pgwipeout@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The rockchip-sfc driver sanity checks the maximum frequency, but not the minimum frequency. This causes the probe to fail when a frequency isn't defined, such as with `sf probe 0`. Clamp the minimum frequency to the rockchip default clock rate. Signed-off-by: Peter Geis --- drivers/spi/rockchip_sfc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/rockchip_sfc.c b/drivers/spi/rockchip_sfc.c index 851a6482985b..d0d2dc70a417 100644 --- a/drivers/spi/rockchip_sfc.c +++ b/drivers/spi/rockchip_sfc.c @@ -164,6 +164,8 @@ /* DMA is only enabled for large data transmission */ #define SFC_DMA_TRANS_THRETHOLD (0x40) +#define SFC_MIN_SPEED (24 * 1000 * 1000) + /* Maximum clock values from datasheet suggest keeping clock value under * 150MHz. No minimum or average value is suggested. */ @@ -596,6 +598,9 @@ static int rockchip_sfc_set_speed(struct udevice *bus, uint speed) if (speed > sfc->max_freq) speed = sfc->max_freq; + if (speed < SFC_MIN_SPEED) + speed = SFC_MIN_SPEED; + if (speed == sfc->speed) return 0; -- 2.25.1