public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Geis <pgwipeout@gmail.com>
To: Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Kever Yang <kever.yang@rock-chips.com>
Cc: Peter Geis <pgwipeout@gmail.com>, u-boot@lists.denx.de
Subject: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl
Date: Mon, 21 Feb 2022 20:31:25 -0500	[thread overview]
Message-ID: <20220222013131.3114990-7-pgwipeout@gmail.com> (raw)
In-Reply-To: <20220222013131.3114990-1-pgwipeout@gmail.com>

Fixup the bootrom recovery mode code to function in spl, so we can
handle recovery mode in case u-boot loading is broken.

Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
 arch/arm/mach-rockchip/Makefile        |  6 +++---
 arch/arm/mach-rockchip/boot_mode.c     |  4 +++-
 arch/arm/mach-rockchip/rk3568/rk3568.c | 23 +++++++++++++++++++++++
 3 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile
index 00aef0ecee6a..53aff25ce8f6 100644
--- a/arch/arm/mach-rockchip/Makefile
+++ b/arch/arm/mach-rockchip/Makefile
@@ -15,13 +15,13 @@ obj-tpl-$(CONFIG_ROCKCHIP_PX30) += px30-board-tpl.o
 
 obj-spl-$(CONFIG_ROCKCHIP_RK3036) += rk3036-board-spl.o
 
-ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TPL_BUILD),)
-
 # Always include boot_mode.o, as we bypass it (i.e. turn it off)
 # inside of boot_mode.c when CONFIG_BOOT_MODE_REG is 0.  This way,
 # we can have the preprocessor correctly recognise both 0x0 and 0
 # meaning "turn it off".
-obj-y += boot_mode.o
+obj-$(CONFIG_ARCH_ROCKCHIP) += boot_mode.o
+
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TPL_BUILD),)
 obj-$(CONFIG_ROCKCHIP_COMMON_BOARD) += board.o
 obj-$(CONFIG_MISC_INIT_R) += misc.o
 endif
diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c
index 1a1a887fc2cd..43cb369465a2 100644
--- a/arch/arm/mach-rockchip/boot_mode.c
+++ b/arch/arm/mach-rockchip/boot_mode.c
@@ -51,7 +51,7 @@ __weak int rockchip_dnl_key_pressed(void)
 	ret = -ENODEV;
 	uclass_foreach_dev(dev, uc) {
 		if (!strncmp(dev->name, "saradc", 6)) {
-			ret = adc_channel_single_shot(dev->name, 1, &val);
+			ret = adc_channel_single_shot(dev->name, 0, &val);
 			break;
 		}
 	}
@@ -89,6 +89,7 @@ int setup_boot_mode(void)
 	boot_mode = readl(reg);
 	debug("%s: boot mode 0x%08x\n", __func__, boot_mode);
 
+#if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_TPL_BUILD)
 	/* Clear boot mode */
 	writel(BOOT_NORMAL, reg);
 
@@ -102,6 +103,7 @@ int setup_boot_mode(void)
 		env_set("preboot", "setenv preboot; ums mmc 0");
 		break;
 	}
+#endif
 
 	return 0;
 }
diff --git a/arch/arm/mach-rockchip/rk3568/rk3568.c b/arch/arm/mach-rockchip/rk3568/rk3568.c
index 22eeb77d41fa..4e23feb9417f 100644
--- a/arch/arm/mach-rockchip/rk3568/rk3568.c
+++ b/arch/arm/mach-rockchip/rk3568/rk3568.c
@@ -104,3 +104,26 @@ int arch_cpu_init(void)
 #endif
 	return 0;
 }
+
+#ifdef CONFIG_SPL_BUILD
+
+void __weak led_setup(void)
+{
+}
+
+void spl_board_init(void)
+{
+	led_setup();
+
+#if defined(SPL_DM_REGULATOR)
+	/*
+	 * Turning the eMMC and SPI back on (if disabled via the Qseven
+	 * BIOS_ENABLE) signal is done through a always-on regulator).
+	 */
+	if (regulators_enable_boot_on(false))
+		debug("%s: Cannot enable boot on regulator\n", __func__);
+#endif
+
+	setup_boot_mode();
+}
+#endif
-- 
2.25.1


  parent reply	other threads:[~2022-02-22  1:33 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22  1:31 [PATCH v1 00/11] rockchip fixes and extend rk3568 support Peter Geis
2022-02-22  1:31 ` [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler Peter Geis
2022-03-12  2:24   ` Simon Glass
2022-03-12  3:32     ` Peter Geis
2022-03-12  5:02       ` Simon Glass
2022-03-14  8:51   ` Kever Yang
2023-01-04 18:30   ` Jagan Teki
2022-02-22  1:31 ` [PATCH v1 02/11] mmc: sdhci: allow disabling sdma in spl Peter Geis
2022-02-25  1:46   ` Jaehoon Chung
2022-03-14  8:41   ` Kever Yang
2022-02-22  1:31 ` [PATCH v1 03/11] spi: rockchip-sfc: fix building rockchip-sfc Peter Geis
2022-03-14  8:45   ` Kever Yang
2022-03-14 11:36     ` Peter Geis
2022-02-22  1:31 ` [PATCH v1 04/11] spi: rockchip-sfc: sanity check minimum freq Peter Geis
2022-03-14  8:53   ` Kever Yang
2022-03-15  2:10     ` Jon Lin
2022-02-22  1:31 ` [PATCH v1 05/11] spl: support adc drivers in spl Peter Geis
2022-02-22  1:31 ` Peter Geis [this message]
2022-03-12  2:24   ` [PATCH v1 06/11] rockchip: handle bootrom recovery mode " Simon Glass
2022-03-12  3:37     ` Peter Geis
2022-03-14  9:08   ` Kever Yang
2022-03-14 11:51     ` Peter Geis
2022-03-14 11:59   ` Philipp Tomsich
2022-03-14 12:34     ` Peter Geis
2022-02-22  1:31 ` [PATCH v1 07/11] rockchip: rk3568: add boot device detection Peter Geis
2022-03-12  2:24   ` Simon Glass
2022-03-12  3:34     ` Peter Geis
2022-02-22  1:31 ` [PATCH v1 08/11] rockchip: rk3568: enable automatic clock gating Peter Geis
2022-03-12  2:24   ` Simon Glass
2022-03-14  8:52   ` Kever Yang
2022-02-22  1:31 ` [PATCH v1 09/11] rockchip: move dwc3 config to chip specific handler Peter Geis
2022-03-12  2:24   ` Simon Glass
2023-02-27  7:10   ` Jagan Teki
2022-02-22  1:31 ` [PATCH v1 10/11] rockchip: rk3568: add dwc3 otg support Peter Geis
2022-03-12  2:24   ` Simon Glass
2022-03-12  3:38     ` Peter Geis
2022-02-22  1:31 ` [PATCH v1 11/11] [RFC] rockchip: rk356x: attempt to fix ram detection Peter Geis
2022-03-12  2:24   ` Simon Glass
2022-03-12  3:54     ` Peter Geis
2022-03-12  5:02       ` Simon Glass
2022-03-12 14:46 ` [PATCH v1 00/11] rockchip fixes and extend rk3568 support Kever Yang
2022-03-14  8:56 ` Kever Yang
2022-03-14 11:42   ` Peter Geis
2022-03-14  9:06 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222013131.3114990-7-pgwipeout@gmail.com \
    --to=pgwipeout@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox