public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node
@ 2022-02-23  9:48 Heiko Thiery
  2022-02-23  9:48 ` [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee " Heiko Thiery
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Heiko Thiery @ 2022-02-23  9:48 UTC (permalink / raw)
  To: u-boot
  Cc: Stefano Babic, Michael Walle, Fabio Estevam,
	NXP i . MX U-Boot Team, Peng Fan, Frieder Schrempf, Marek Vasut,
	Heiko Thiery

To be in sync with the linux devicetree change the 'phy-reset-gpios' in
the fec node to 'reset-gpios' in the phy node. The PHY reset will be
done by the eth-phy-uclass driver while probing the PHY. This is ok
since it is done before probing the fec.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 arch/arm/dts/imx8mn-evk.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi
index fc2c7f1d44..ed865444da 100644
--- a/arch/arm/dts/imx8mn-evk.dtsi
+++ b/arch/arm/dts/imx8mn-evk.dtsi
@@ -53,7 +53,6 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
-	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 	fsl,magic-packet;
 	status = "okay";
 
@@ -64,6 +63,8 @@
 		ethphy0: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0>;
+			reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
 			vddio-supply = <&vddio>;
 
 			vddio: vddio-regulator {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee phy node
  2022-02-23  9:48 [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node Heiko Thiery
@ 2022-02-23  9:48 ` Heiko Thiery
  2022-02-24  4:06   ` Marek Vasut
  2022-02-24  4:06 ` [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in " Marek Vasut
  2022-02-24 11:16 ` Fabio Estevam
  2 siblings, 1 reply; 5+ messages in thread
From: Heiko Thiery @ 2022-02-23  9:48 UTC (permalink / raw)
  To: u-boot
  Cc: Stefano Babic, Michael Walle, Fabio Estevam,
	NXP i . MX U-Boot Team, Peng Fan, Frieder Schrempf, Marek Vasut,
	Heiko Thiery

To be in sync with the linux devicetree add the disable-smarteee
property.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 arch/arm/dts/imx8mn-evk.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi
index ed865444da..fd253f0042 100644
--- a/arch/arm/dts/imx8mn-evk.dtsi
+++ b/arch/arm/dts/imx8mn-evk.dtsi
@@ -65,6 +65,7 @@
 			reg = <0>;
 			reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
+			qca,disable-smarteee;
 			vddio-supply = <&vddio>;
 
 			vddio: vddio-regulator {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node
  2022-02-23  9:48 [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node Heiko Thiery
  2022-02-23  9:48 ` [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee " Heiko Thiery
@ 2022-02-24  4:06 ` Marek Vasut
  2022-02-24 11:16 ` Fabio Estevam
  2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2022-02-24  4:06 UTC (permalink / raw)
  To: Heiko Thiery, u-boot
  Cc: Stefano Babic, Michael Walle, Fabio Estevam,
	NXP i . MX U-Boot Team, Peng Fan, Frieder Schrempf

On 2/23/22 10:48, Heiko Thiery wrote:
> To be in sync with the linux devicetree change the 'phy-reset-gpios' in
> the fec node to 'reset-gpios' in the phy node. The PHY reset will be
> done by the eth-phy-uclass driver while probing the PHY. This is ok
> since it is done before probing the fec.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Tested-by: Marek Vasut <marex@denx.de> # 8MNANOD4-EVK

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee phy node
  2022-02-23  9:48 ` [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee " Heiko Thiery
@ 2022-02-24  4:06   ` Marek Vasut
  0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2022-02-24  4:06 UTC (permalink / raw)
  To: Heiko Thiery, u-boot
  Cc: Stefano Babic, Michael Walle, Fabio Estevam,
	NXP i . MX U-Boot Team, Peng Fan, Frieder Schrempf

On 2/23/22 10:48, Heiko Thiery wrote:
> To be in sync with the linux devicetree add the disable-smarteee
> property.

Tested-by: Marek Vasut <marex@denx.de> # 8MNANOD4-EVK

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node
  2022-02-23  9:48 [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node Heiko Thiery
  2022-02-23  9:48 ` [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee " Heiko Thiery
  2022-02-24  4:06 ` [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in " Marek Vasut
@ 2022-02-24 11:16 ` Fabio Estevam
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-02-24 11:16 UTC (permalink / raw)
  To: Heiko Thiery
  Cc: U-Boot-Denx, Stefano Babic, Michael Walle, NXP i . MX U-Boot Team,
	Peng Fan, Frieder Schrempf, Marek Vasut

On Wed, Feb 23, 2022 at 6:48 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> To be in sync with the linux devicetree change the 'phy-reset-gpios' in
> the fec node to 'reset-gpios' in the phy node. The PHY reset will be
> done by the eth-phy-uclass driver while probing the PHY. This is ok
> since it is done before probing the fec.
>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-24 11:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-23  9:48 [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in phy node Heiko Thiery
2022-02-23  9:48 ` [PATCH 2/2] ARM: imx: imx8mn-*-evk: add qca, disable-smarteee " Heiko Thiery
2022-02-24  4:06   ` Marek Vasut
2022-02-24  4:06 ` [PATCH 1/2] ARM: imx: imx8mn-*-evk: use reset-gpios in " Marek Vasut
2022-02-24 11:16 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox