From: "Marek Behún" <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>, u-boot@lists.denx.de
Subject: Re: [PATCH u-boot-mvebu] watchdog: armada_37xx: Probe driver also when watchdog is already running
Date: Wed, 23 Feb 2022 15:35:37 +0100 [thread overview]
Message-ID: <20220223153537.6a9ae4b5@thinkpad> (raw)
In-Reply-To: <20220223132140.12529-1-pali@kernel.org>
On Wed, 23 Feb 2022 14:21:40 +0100
Pali Rohár <pali@kernel.org> wrote:
> If Armada 37xx watchdog is started before U-Boot then CNTR_CTRL_ACTIVE bit
> is set, U-Boot armada-37xx-wdt.c driver fails to initialize and so U-Boot
> is unable to use or kick this watchdog.
>
> Do not check for CNTR_CTRL_ACTIVE bit and always initialize watchdog. Same
> behavior is implemented in Linux kernel driver.
>
> This change allows to activate watchdog in firmware which loads U-Boot.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
next prev parent reply other threads:[~2022-02-23 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:21 [PATCH u-boot-mvebu] watchdog: armada_37xx: Probe driver also when watchdog is already running Pali Rohár
2022-02-23 14:35 ` Marek Behún [this message]
2022-03-04 7:27 ` Stefan Roese
2022-03-08 9:10 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223153537.6a9ae4b5@thinkpad \
--to=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox