From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9030AC433EF for ; Wed, 23 Feb 2022 14:35:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0A07B838AE; Wed, 23 Feb 2022 15:35:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="EaTuYHnd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE9EE83A9D; Wed, 23 Feb 2022 15:35:41 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D1A75838AE for ; Wed, 23 Feb 2022 15:35:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id 50DFD140BEF; Wed, 23 Feb 2022 15:35:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1645626938; bh=j8P7hReSnqw4zFvd+gHNd47olt/XTorI9Hp3Lw3rb38=; h=Date:From:To; b=EaTuYHnde5HjM8tr0RIvZ9jEHqscuNcs3G9fOzgdQR3ATDUGaAsrqS/zZEbdZSjI0 SdANv2evCDko5fVFwdB1LaxhXx8mUr5h5Q2w+sC3iXrMy340n83k1sBo9/lN+akTOh 4dFHQaRQpWfuztBnxi5LbP7+2C4FOToAGAdRY0xU= Date: Wed, 23 Feb 2022 15:35:37 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-mvebu] watchdog: armada_37xx: Probe driver also when watchdog is already running Message-ID: <20220223153537.6a9ae4b5@thinkpad> In-Reply-To: <20220223132140.12529-1-pali@kernel.org> References: <20220223132140.12529-1-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 23 Feb 2022 14:21:40 +0100 Pali Roh=C3=A1r wrote: > If Armada 37xx watchdog is started before U-Boot then CNTR_CTRL_ACTIVE bit > is set, U-Boot armada-37xx-wdt.c driver fails to initialize and so U-Boot > is unable to use or kick this watchdog. >=20 > Do not check for CNTR_CTRL_ACTIVE bit and always initialize watchdog. Same > behavior is implemented in Linux kernel driver. >=20 > This change allows to activate watchdog in firmware which loads U-Boot. >=20 > Signed-off-by: Pali Roh=C3=A1r Reviewed-by: Marek Beh=C3=BAn