From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Simon Glass <sjg@chromium.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH] tools: mkimage/dumpimage: Allow to use -l with -T
Date: Mon, 28 Feb 2022 15:46:52 -0500 [thread overview]
Message-ID: <20220228204652.GC9438@bill-the-cat> (raw)
In-Reply-To: <20220213000946.16236-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Sun, Feb 13, 2022 at 01:09:46AM +0100, Pali Rohár wrote:
> Currently -l option for mkimage and dumpimage ignores option -T and always
> tries to autodetect image type.
>
> With this change it is possible to tell mkimage and dumpimage to parse
> image file as specific type (and not random autodetected type). This allows
> to use mkimage -l or dumpimage -l as tool for validating image.
>
> params.type for -l option is now by default initialized to zero
> (IH_TYPE_INVALID) instead of IH_TYPE_KERNEL. imagetool_get_type() for
> IH_TYPE_INVALID returns NULL, which is assigned to tparams. mkimage and
> dumpimage code is extended to handle tparams with NULL for -l option. And
> imagetool_verify_print_header() is extended to do validation via tparams if
> is not NULL.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-02-28 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 0:09 [PATCH] tools: mkimage/dumpimage: Allow to use -l with -T Pali Rohár
2022-02-26 18:37 ` Simon Glass
2022-02-28 20:46 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228204652.GC9438@bill-the-cat \
--to=trini@konsulko.com \
--cc=jan.kiszka@siemens.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox