From: Tim Harvey <tharvey@gateworks.com>
To: u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Cc: Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH 0/2] prevent undesired de-assertion of phy-reset
Date: Tue, 1 Mar 2022 12:15:00 -0800 [thread overview]
Message-ID: <20220301201502.28026-1-tharvey@gateworks.com> (raw)
Some PHY's have strict requirements on reset timings which can be
violated if the PHY is taken out of reset before a proper reset pulse is
performed.
When gpio_request_by_name is used for reset gpios without
GPIOD_IS_OUT_ACTIVE the GPIO will be de-asserted when requested taking
the PHY out of reset. Resolve this by adding the GPIOD_IS_OUT_ACTIVE
flag.
There are 42 occurances of gpio_request_by_name in U-Boot for gpio's
with 'reset' in their name yet the only one that uses
GPIOD_IS_OUT_ACTIVE is drivers/net/dwc_eth_qos.c. While I think setting
GPIOD_IS_OUT_ACTIVE is the right thing to do, I'm only changing the ones
that I have run into issues with:
drivers/net/eth-phy-uclass.c
drivers/net/fec_mxc.c
Both of these have functions that are called that assert, delay,
de-assert, delay such that I know they will properly be taken out of
reset.
The Linux kernel had a similar issue [1]
Tim Harvey (2):
net: fec: prevent undesired de-assertion of phy-reset on request
net: eth-phy: prevent undesired de-assertion of phy-reset on request
drivers/net/eth-phy-uclass.c | 2 +-
drivers/net/fec_mxc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
[1]
https://lore.kernel.org/all/20210202143239.10714-1-mike.looijmans@topic.nl/
2.17.1
next reply other threads:[~2022-03-01 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 20:15 Tim Harvey [this message]
2022-03-01 20:15 ` [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request Tim Harvey
2022-03-01 20:38 ` Joe Hershberger
2022-03-02 1:58 ` Adam Ford
2022-03-03 7:55 ` Ramon Fried
2022-04-10 5:05 ` Ramon Fried
2022-03-01 20:15 ` [PATCH 2/2] net: eth-phy: " Tim Harvey
2022-03-01 20:38 ` Joe Hershberger
2022-03-03 7:55 ` Ramon Fried
2022-04-10 5:05 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301201502.28026-1-tharvey@gateworks.com \
--to=tharvey@gateworks.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox