Re: [PATCH 2/2] net: eth-phy: prevent undesired de-assertion of phy-reset on request

Ramon Fried
2022-04-10T05:05:32Z

On Thu, Mar 3, 2022 at 9:55 AM Ramon Fried <rfried.dev@gmail.com> wrote:
>
> On Tue, Mar 1, 2022 at 10:38 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > When gpio_request_by_name allocates a gpio output it by default will
> > > de-assert the gpio which for phy-reset will take the PHY out of reset.
> > > As this occurs before eth_phy_reset is called to assert the reset
> > > line it can cause undesired affects if reset timings are not properly
> > > met.
> > >
> > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active
> > > (reset asserted) to avoid this.
> > >
> > > Cc: Sean Anderson <sean.anderson@seco.com>
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot-net/next
Thanks,
Ramon