From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8979BC433EF for ; Wed, 2 Mar 2022 11:51:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1928083CBE; Wed, 2 Mar 2022 12:50:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="vHGxlkuC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A327883C60; Wed, 2 Mar 2022 12:49:59 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA7088312A for ; Wed, 2 Mar 2022 12:49:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91DB8B81F71; Wed, 2 Mar 2022 11:49:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32164C340E9; Wed, 2 Mar 2022 11:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646221777; bh=HlKA9flF/hRDtdBL8EC8rdgNQcBiDJH5++/OEYFsEdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vHGxlkuCS84+/xNHL2lj1jSP86e4PAB+wpk5Rt+Ch3lLpxS4GfW54hb/rb5ATTa34 gTDWCizz49YhoqwlOqdyrGgHaJW8CU3FEhjx7i3oV4rHCb86Q7C8sDE4dybqi4gUOB Z+nseSZqkWR1W7T3ueUtaju3FFMvVubxH4KAkGa7knasysMzIgbTpaHP2YAntzfwkO vPayyeC7cy1ZAvEmhSJ4VcHiwrHVKaYSp6JWCOrzIny6Sqo3jyYdBy/bRcJvdEr+Hq OA1aUt9jAU020+yp+uqy4pItOwjlYY3ZE50EKnJfODQYQ3VMC8BzJAjTyYqPx49T92 oWQveY8GYz50Q== Received: by pali.im (Postfix) id E13A9677; Wed, 2 Mar 2022 12:49:36 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Stefan Roese , =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: u-boot@lists.denx.de Subject: [PATCH u-boot-marvell 7/8] arm: mvebu: turris_omnia: Signal error when sata/pcie DT mode Date: Wed, 2 Mar 2022 12:47:57 +0100 Message-Id: <20220302114758.21787-8-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220302114758.21787-1-pali@kernel.org> References: <20220302114758.21787-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Show error message when DT file does not contain sata or pcie node which should be explicitly disabled. This can happen when U-Boot code for finding those nodes is incomplete or when those DT nodes are in different unexpected location. In any case it is needed to know if DT not was not explicitly disabled as it could mean that combo slots where setup incorrectly. Signed-off-by: Pali Rohár --- board/CZ.NIC/turris_omnia/turris_omnia.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c index 57b797db4a8e..e2f4daa827ed 100644 --- a/board/CZ.NIC/turris_omnia/turris_omnia.c +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c @@ -531,8 +531,10 @@ static void disable_sata_node(void *blob) else debug("Disabled SATA DT node\n"); - break; + return; } + + printf("Cannot find SATA DT node!\n"); } static void disable_pcie_node(void *blob, int port) @@ -560,6 +562,8 @@ static void disable_pcie_node(void *blob, int port) return; } } + + printf("Cannot find PCIe port %d DT node!\n", port); } static void fixup_msata_port_nodes(void *blob) -- 2.20.1