From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ED3BC433F5 for ; Wed, 2 Mar 2022 12:36:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24BCB83C75; Wed, 2 Mar 2022 13:36:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="UHOu2Khz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D6F483C60; Wed, 2 Mar 2022 13:36:33 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38D9B83C88 for ; Wed, 2 Mar 2022 13:36:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id AAECC140A47; Wed, 2 Mar 2022 13:36:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1646224587; bh=4gIlP8phZ8ozP3IvlGMTsl2B3FonzJxqc/TXjAFwzbA=; h=Date:From:To; b=UHOu2KhzswZIuagrz/kd/ckk6g6fBkAkauCq1Brxen4oJCC63tBVQn9GgYNk8LLUs 0J0njD+MAOneCftsDkLojq/8phP2PU65Kp83mUDjh9AHtiOm/1bnqQy1urcZSajTFE EaSQIPGC0GHGG7Tph/cbCzajnPDMd98lgPD/HY8Q= Date: Wed, 2 Mar 2022 13:36:26 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-marvell 5/8] arm: mvebu: turris_omnia: Allow to configure mSATA slot via env variable Message-ID: <20220302133626.25fe185d@dellmb> In-Reply-To: <20220302114758.21787-6-pali@kernel.org> References: <20220302114758.21787-1-pali@kernel.org> <20220302114758.21787-6-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > { > - if (omnia_detect_sata()) { > +#ifdef CONFIG_SPL_ENV_SUPPORT > + /* Do not use env_load() as malloc() pool is too small at this stage */ > + bool has_env = (env_init() == 0); > +#endif > + const char *env_value = NULL; > + > +#ifdef CONFIG_SPL_ENV_SUPPORT > + /* beware that env_get() returns static allocated memory */ > + env_value = has_env ? env_get("omnia_msata_slot") : NULL; > +#endif Can we use if (IS_ENABLED(CONFIG_SPL_ENV_SUPPORT)) instead of macros here? Marek