Re: [PATCH v3 06/12] rockchip: rk3288-power: sync power domain dt-binding header from Linux

Kever Yang
2022-03-28T12:46:46Z

On 2022/3/4 07:52, Johan Jonker wrote:
> In order to update the DT for rk3288
> sync the power domain dt-binding header.
> This is the state as of v5.17 in Linux.
> Change location to be more in line with other SoCs.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
> Changed V2:
> changed include rk3288.dtsi
> ---
> arch/arm/dts/rk3288.dtsi | 2 +-
> include/dt-bindings/power-domain/rk3288.h | 11 --------
> include/dt-bindings/power/rk3288-power.h | 32 +++++++++++++++++++++++
> 3 files changed, 33 insertions(+), 12 deletions(-)
> delete mode 100644 include/dt-bindings/power-domain/rk3288.h
> create mode 100644 include/dt-bindings/power/rk3288-power.h
>
> diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi
> index 22bb06ce..2086dbfd 100644
> --- a/arch/arm/dts/rk3288.dtsi
> +++ b/arch/arm/dts/rk3288.dtsi
> @@ -5,7 +5,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> #include <dt-bindings/clock/rk3288-cru.h>
> -#include <dt-bindings/power-domain/rk3288.h>
> +#include <dt-bindings/power/rk3288-power.h>
> #include <dt-bindings/thermal/thermal.h>
> #include <dt-bindings/video/rk3288.h>
> #include "skeleton.dtsi"
> diff --git a/include/dt-bindings/power-domain/rk3288.h b/include/dt-bindings/power-domain/rk3288.h
> deleted file mode 100644
> index ca68c114..00000000
> --- a/include/dt-bindings/power-domain/rk3288.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#ifndef __DT_BINDINGS_POWER_DOMAIN_RK3288_H__
> -#define __DT_BINDINGS_POWER_DOMAIN_RK3288_H__
> -
> -/* RK3288 power domain index */
> -#define RK3288_PD_GPU 0
> -#define RK3288_PD_VIO 1
> -#define RK3288_PD_VIDEO 2
> -#define RK3288_PD_HEVC 3
> -#define RK3288_PD_PERI 4
> -
> -#endif
> diff --git a/include/dt-bindings/power/rk3288-power.h b/include/dt-bindings/power/rk3288-power.h
> new file mode 100644
> index 00000000..f710b56c
> --- /dev/null
> +++ b/include/dt-bindings/power/rk3288-power.h
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __DT_BINDINGS_POWER_RK3288_POWER_H__
> +#define __DT_BINDINGS_POWER_RK3288_POWER_H__
> +
> +/**
> + * RK3288 Power Domain and Voltage Domain Summary.
> + */
> +
> +/* VD_CORE */
> +#define RK3288_PD_A17_0 0
> +#define RK3288_PD_A17_1 1
> +#define RK3288_PD_A17_2 2
> +#define RK3288_PD_A17_3 3
> +#define RK3288_PD_SCU 4
> +#define RK3288_PD_DEBUG 5
> +#define RK3288_PD_MEM 6
> +
> +/* VD_LOGIC */
> +#define RK3288_PD_BUS 7
> +#define RK3288_PD_PERI 8
> +#define RK3288_PD_VIO 9
> +#define RK3288_PD_ALIVE 10
> +#define RK3288_PD_HEVC 11
> +#define RK3288_PD_VIDEO 12
> +
> +/* VD_GPU */
> +#define RK3288_PD_GPU 13
> +
> +/* VD_PMU */
> +#define RK3288_PD_PMU 14
> +
> +#endif