Re: [PATCH v3 12/12] rockchip: fix boot_devices constants

Simon Glass
2022-03-12T02:26:37Z

Hi Johan,

On Thu, 3 Mar 2022 at 16:53, Johan Jonker <jbx6244@gmail.com> wrote:
>
> The DT node name pattern in mmc-controller.yaml for mmc
> is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced
> with Linux, so update the boot_devices constants as well.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/mach-rockchip/rk3188/rk3188.c | 4 ++--
> arch/arm/mach-rockchip/rk322x/rk322x.c | 4 ++--
> arch/arm/mach-rockchip/rk3288/rk3288.c | 4 ++--
> arch/arm/mach-rockchip/rk3328/rk3328.c | 4 ++--
> arch/arm/mach-rockchip/rk3368/rk3368.c | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)

This series seems to work OK on snow. But on jerry I get:

U-Boot 2022.04-rc3-00077-g088bbcb3fad (Mar 11 2022 - 15:59:54 -0700)

Model: Google Jerry
DRAM: 2 GiB
PMIC: RK808
Core: 256 devices, 25 uclasses, devicetree: separate
MMC: mmc@ff0c0000: 1, mmc@ff0d0000: 2, mmc@ff0f0000: 0
Loading Environment from nowhere... OK
cros_ec_spi_command: Returned status 6
cros_ec_check_version: ERROR: old EC interface not supported
Failed to probe keyboard 'keyboard-controller'
rockchip_rk3288_vop vop@ff930000: failed to get ahb reset (ret=-524)
rockchip_rk3288_vop vop@ff930000: failed to get ahb reset (ret=-524)
In: serial

So it seems the EC and video devicetree are broken in some way, or
drivers need updating for new bindings?

[..]

Regards,
Simon