Re: [PATCH v4 2/3] ARM: dts: at91: sama5d2: add TCB node

Eugen.Hristev
2022-03-04T10:14:22Z

On 3/4/22 11:49 AM, Clément Léger wrote:
> Le Fri, 4 Mar 2022 10:46:45 +0100,
> Clément Léger <clement.leger@bootlin.com> a écrit :
>
>> Le Fri, 4 Mar 2022 10:45:21 +0100,
>> Clément Léger <clement.leger@bootlin.com> a écrit :
>>
>>> Add the device-tree node to describe the TCB timer.
>>>
>>> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
>>> ---
>>> arch/arm/dts/sama5d2.dtsi | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
>>> index 038cd73c03..54f3dd4c62 100644
>>> --- a/arch/arm/dts/sama5d2.dtsi
>>> +++ b/arch/arm/dts/sama5d2.dtsi
>>> @@ -700,6 +700,22 @@
>>> clocks = <&h32ck>;
>>> };
>>>
>>> + tcb0: timer@f800c000 {
>>> + compatible = "atmel,sama5d2-tcb", "simple-mfd",
>>> + "syscon";
>>> + reg = <0xf800c000 0x100>;
>>> + interrupts = <35 IRQ_TYPE_LEVEL_HIGH 0>;
>>
>> And I forgot to include the file which defines IRQ_TYPE_LEVEL_HIGH. Will
>> need a V5 I guess.
>
> By the way, this will also yield the following warning:
>
> arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property):
> /ahb/apb/timer@f800c000: Missing interrupt-parent
>
> Because indeed, there is no interrupt controller declared at all in
> this device-tree. What can I do about that ?

I know. You have to add the interrupt controller.
That's why I wanted to avoid having interrupts as mandatory, but it
looks it's not possible.

>
>>
>>> + clocks = <&tcb0_clk>, <&tcb0_gclk>, <&clk32k>;
>>> + clock-names = "t0_clk", "gclk", "slow_clk";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + timer0: timer@0 {
>>> + compatible = "atmel,tcb-timer";
>>> + reg = <0>, <1>;
>>> + };
>>> + };
>>> +
>>> watchdog@f8048040 {
>>> compatible = "atmel,sama5d4-wdt";
>>> reg = <0xf8048040 0x10>;
>>
>>
>>
>
>
>
> --
> Clément Léger,
> Embedded Linux and Kernel engineer at Bootlin
> https://bootlin.com
>