From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D27C433EF for ; Fri, 4 Mar 2022 09:51:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F64983BB0; Fri, 4 Mar 2022 10:50:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="kbGZsU51"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2FCAF83CB7; Fri, 4 Mar 2022 10:50:57 +0100 (CET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EC33C83689 for ; Fri, 4 Mar 2022 10:50:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clement.leger@bootlin.com Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0DEC8FF80D; Fri, 4 Mar 2022 09:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646387453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMcXOkFpniNilFZY8lRDGRpoq3gFuEQMou0tupzQle0=; b=kbGZsU51XGeMLWSQxgjUm00vtY1+tZi9d94KJK8o7W1zvmdgEbmOkMDJjgNd20gzXUYNtg Y24a1I7SoTYeGX+bzC+XNRAuLLxAB8JjX7V2lpBxN/fXDeQUVXKC3rGc4EixvDsiJit8CP k6TQF5JbKhwjPxLn7lb1+HM7fZJacYnwPvkDqc6caJ6WelSdaXZ7XfiVe2s0GkRGK6ICaZ EQUHebXRSjem67HbPfOzRXyxnVJXa3bStGh6HgLG9qxC98pZohwZY659ZGgu6/fyIlPMau mk3dv8l9QvaRuTIN7TdpdIRrHDl5fxAf4uYkxwIXWLwVnsNqIM1LGF8rS+G2rw== Date: Fri, 4 Mar 2022 10:49:28 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Eugen Hristev , Ludovic Desroches Cc: u-boot@lists.denx.de, Nicolas Ferre , Thomas Petazzoni , Claudiu Beznea Subject: Re: [PATCH v4 2/3] ARM: dts: at91: sama5d2: add TCB node Message-ID: <20220304104928.6cbf3b4c@fixe.home> In-Reply-To: <20220304104645.15729c02@fixe.home> References: <20220304094522.47714-1-clement.leger@bootlin.com> <20220304094522.47714-3-clement.leger@bootlin.com> <20220304104645.15729c02@fixe.home> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Le Fri, 4 Mar 2022 10:46:45 +0100, Cl=C3=A9ment L=C3=A9ger a =C3=A9crit : > Le Fri, 4 Mar 2022 10:45:21 +0100, > Cl=C3=A9ment L=C3=A9ger a =C3=A9crit : >=20 > > Add the device-tree node to describe the TCB timer. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > arch/arm/dts/sama5d2.dtsi | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > >=20 > > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi > > index 038cd73c03..54f3dd4c62 100644 > > --- a/arch/arm/dts/sama5d2.dtsi > > +++ b/arch/arm/dts/sama5d2.dtsi > > @@ -700,6 +700,22 @@ > > clocks =3D <&h32ck>; > > }; > > =20 > > + tcb0: timer@f800c000 { > > + compatible =3D "atmel,sama5d2-tcb", "simple-mfd", > > + "syscon"; > > + reg =3D <0xf800c000 0x100>; > > + interrupts =3D <35 IRQ_TYPE_LEVEL_HIGH 0>; =20 >=20 > And I forgot to include the file which defines IRQ_TYPE_LEVEL_HIGH. Will > need a V5 I guess. By the way, this will also yield the following warning: arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property): /ahb/apb/timer@f800c000: Missing interrupt-parent Because indeed, there is no interrupt controller declared at all in this device-tree. What can I do about that ? >=20 > > + clocks =3D <&tcb0_clk>, <&tcb0_gclk>, <&clk32k>; > > + clock-names =3D "t0_clk", "gclk", "slow_clk"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + timer0: timer@0 { > > + compatible =3D "atmel,tcb-timer"; > > + reg =3D <0>, <1>; > > + }; > > + }; > > + > > watchdog@f8048040 { > > compatible =3D "atmel,sama5d4-wdt"; > > reg =3D <0xf8048040 0x10>; =20 >=20 >=20 >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com