From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1334C433F5 for ; Fri, 4 Mar 2022 14:43:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 044E48365D; Fri, 4 Mar 2022 15:43:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="DeTauD1J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A1DC83689; Fri, 4 Mar 2022 15:43:45 +0100 (CET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E0D1E82FCA for ; Fri, 4 Mar 2022 15:43:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clement.leger@bootlin.com Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0547A100011; Fri, 4 Mar 2022 14:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646405020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wk25zag5nHpNenJPSz4g4MW9ES1jG9qWgiB7i6JnPHg=; b=DeTauD1JBjA5G7TcDxHLggF2q4jSEmvTskXvGCjeqb9Gd5jZuuupAMJ7CR521OfCWw58Bg yjPcM2AdO6/Fk0mtXFLQw75yxLFXbF527+s4CvAXns2OtIN8yoPY7qbHB08JM2a0K+QUq1 k2GnjLgT1DCN1rDcvDbDAe5MLYbxo5EAQSL9j74a8vX399nvlunFopWAj19LW8UNvgW1mZ HjozEaD0yBm65rb+mR55atj+44wDZW9xseEMj8T5bZOyLxzhWxCcmgMMH0ebrNAjB5WYNl a3yuSkTQKh9t7XLYRfHEiTMPBts4d2VsQYGZpG2eysupmiOqrlh8mCpXOa+RPw== Date: Fri, 4 Mar 2022 15:42:15 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Cc: , , , , Subject: Re: [PATCH v5 3/4] ARM: dts: at91: sama5d2: add TCB node Message-ID: <20220304154215.37d08e17@fixe.home> In-Reply-To: References: <20220304110540.132520-1-clement.leger@bootlin.com> <20220304110540.132520-4-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Le Fri, 4 Mar 2022 14:31:08 +0000, a =C3=A9crit : > On 3/4/22 1:05 PM, Cl=C3=A9ment L=C3=A9ger wrote: > > Add the device-tree node to describe the TCB timer. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > arch/arm/dts/sama5d2.dtsi | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > >=20 > > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi > > index dee68dc022..9360c0008c 100644 > > --- a/arch/arm/dts/sama5d2.dtsi > > +++ b/arch/arm/dts/sama5d2.dtsi > > @@ -1,4 +1,5 @@ > > #include "skeleton.dtsi" > > +#include > >=20 > > / { > > model =3D "Atmel SAMA5D2 family SoC"; > > @@ -710,6 +711,22 @@ > > status =3D "disabled"; > > }; > >=20 > > + tcb0: timer@f800c000 { > > + compatible =3D "atmel,sama5d2-tcb", "si= mple-mfd", > > + "syscon"; =20 >=20 > No need to line break the previous line. DT files can have more than 80=20 > chars per line, it's fine. Ok, wasn't sure of that, found some of them that had these line breaks. Good to know for next patches. >=20 > If there are no other comments I will fix this when applying, no need to= =20 > send a v6 for now. Ok, thanks Eugen. >=20 > > + reg =3D <0xf800c000 0x100>; > > + interrupts =3D <35 IRQ_TYPE_LEVEL_HIGH = 0>; > > + clocks =3D <&tcb0_clk>, <&tcb0_gclk>, <= &clk32k>; > > + clock-names =3D "t0_clk", "gclk", "slow= _clk"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + timer0: timer@0 { > > + compatible =3D "atmel,tcb-timer= "; > > + reg =3D <0>, <1>; > > + }; > > + }; > > + > > watchdog@f8048040 { > > compatible =3D "atmel,sama5d4-wdt"; > > reg =3D <0xf8048040 0x10>; > > -- > > 2.34.1 > > =20 >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com