From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EB92C433F5 for ; Sun, 6 Mar 2022 13:58:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 10851837EC; Sun, 6 Mar 2022 14:58:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D5qOaROQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 15DC983B90; Sun, 6 Mar 2022 14:58:43 +0100 (CET) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1AB3181FDE for ; Sun, 6 Mar 2022 14:58:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id kl20so554467qvb.10 for ; Sun, 06 Mar 2022 05:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dp/JJ7uAUtp0jvpaLO49dnqYQaowsvFsbiHzulItoAQ=; b=D5qOaROQV/QrqRK/EOJmuKUxS70f9O6pZkwaahIdJXXCZsl8a7c8Dgq4dmXAlAdDHw OvU7vnyFcVE6ntDOjF2XcZ5FW1hRv5qDDJI2MRvvmNk7jFpryoOq3Uooul+GAMDQ2y3d 9ELSNgGW7+cVTmus0GbzCqQxK9Ic6RdXYBJ4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dp/JJ7uAUtp0jvpaLO49dnqYQaowsvFsbiHzulItoAQ=; b=RvSQeX7U+se0jlNX7wl+kXmRR4lX9b8165X3dvDWytsr+flYKjT0unCKAXXOlgxjMb HRpGr8ZIV4se6dZSfALoE1q1ElEwbbBfLwVJNfsCnEbbrKaRh7j7+jyBbzcCvstShMWN YL/i+cCHerzXoQ8WX1Ax7T/brFwFAVWNL1ZmF9eIbH3yVM/doJCGk6ha88AJLRFNnboN PEgVfkqb/G3t8V2aP6diIIjjxzRTM7UI/iYFBzBmgi8tHMe2C/N6WxB7kKIA9Sk9k4/M 6gXs5wTQEFAqOBlRwbAFsFb7s2vGYlvmak8IdzCq+DChPMxDMh/FiIsW8mttoIYTiuY0 pWiQ== X-Gm-Message-State: AOAM5337uVa+IN1fo6ycFa0KpDeD0O95NR7uFiUqZtutyi3hIXz5ZMVE 1KgZR0sLpPgAUBrd2NcShLGcfw== X-Google-Smtp-Source: ABdhPJzAt3/QC2VUcXXgiKZ1laNYI0yWp6cnj5muAyd01sAU4Rf2frqsVc+VFd3IXVgkOfYWjmt8ug== X-Received: by 2002:a05:6214:29e9:b0:435:3428:d0f3 with SMTP id jv9-20020a05621429e900b004353428d0f3mr5098033qvb.28.1646575118866; Sun, 06 Mar 2022 05:58:38 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id s10-20020a05620a080a00b0062ce6f3f5d7sm4876598qks.16.2022.03.06.05.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 05:58:38 -0800 (PST) Date: Sun, 6 Mar 2022 08:58:36 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Alexandru Gagniuc , Yann Dirson , Stefan Roese , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk Message-ID: <20220306135836.GK5020@bill-the-cat> References: <20220114173443.9877-1-pali@kernel.org> <20220121212133.GA2826984@bill-the-cat> <20220306115024.qqxab57dh3glmuid@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f8UppZzm5eRNGSBg" Content-Disposition: inline In-Reply-To: <20220306115024.qqxab57dh3glmuid@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --f8UppZzm5eRNGSBg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 06, 2022 at 12:50:24PM +0100, Pali Roh=E1r wrote: > On Friday 21 January 2022 16:21:33 Tom Rini wrote: > > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Roh=E1r wrote: > >=20 > > > If image backend provides verify_header callback then call it after w= riting > > > image to disk. This ensures that written image is correct. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > Reviewed-by: Stefan Roese > > > Reviewed-by: Simon Glass > > > --- > > > tools/mkimage.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 41 insertions(+) > >=20 > > This breaks a number of platforms such as ls1021atwr_sdcard_qspi and > > it's not clear to me why exactly. >=20 > Hello Tom! Is something still blocking this change? Nope, thanks for the reminder. --=20 Tom --f8UppZzm5eRNGSBg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIkvgkACgkQFHw5/5Y0 tyyeogwAjQeeocotHcHS5Oaf3mBF4sJFIOo/iSQepZ6mdvlqg7jeI9yMZnOG5LIO Pe8xUqvcUppuC6OsLfqcZphwcI5D7eEF+SnkucPZ3PehIoIbBoh49aC0mRVvvity oNteJE90i/dgsoQjX3u4yLnuVJIunq6U9qETyKxWLp9sXMWgiq7oXj6CFwT6zkyo p1nY+1+jzSwVeaVhVJsy1FJwQzJdPFnT+oDt5L2eRz1vtveSQjwtTNEoztXpWGLP 2ZZ8Bl0AZoeHmRp3pPbAXk0doVy6DvWc17OM51qp4xSUcqcGot+69Q7d+lXTifzo E7Casr5D0zhfgYhDZpYEx+8x+lm41SPHXnIMRbJSKHDv4EdjUD26I5J9M5YBJNlj XBDbIWcPCULewAxJBLerJDIQ6N/284v8OzoZ/1FUxiZ4D6YjeJMFA4K2iQZMgb6P BM99qTJXVZE/CotVyFpzkPiVkXJmbWfnlnHr1yFndVvu102jt7D6t6L+2akORuWM 2jTCjsr7 =qg7V -----END PGP SIGNATURE----- --f8UppZzm5eRNGSBg--