From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C550C433F5 for ; Wed, 9 Mar 2022 02:49:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5711383976; Wed, 9 Mar 2022 03:48:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="x5Ik7Gq4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A24C83937; Wed, 9 Mar 2022 03:48:56 +0100 (CET) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B97683976 for ; Wed, 9 Mar 2022 03:48:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102a.google.com with SMTP id e3so947146pjm.5 for ; Tue, 08 Mar 2022 18:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=mcftJ0eL1AkWKzPlh7661CQAqOpZ/y4eLGeEn1Mnoik=; b=x5Ik7Gq4NXrZy54UO4A19Aj1psACQpjnFEb9/Rqq/WXUjW3asSUrVJZ/56SI5Lm88/ Llt14tSUnbPWbyqFIK3kcjZ84cdKZL2CVobms+AgY1GKQTsCY5ZJnGOVXVp7ijUjkxi6 UXncNhO+dVgXWOs/2qIDLQ5ESzEHwMYVGWCHkhaCd7HV+4Q9G862KDy3UdhP7wnfuRdF dq03lAG1x4fHq/bp7s3Yu/h6JmjyS2Te2fMBylnyJGg27vIJI4WuH7QoDOL1/iZdaxWy dkNt6OjWY+DSwgNJ63hNdVP2SRazXyMbQ6m1Xh93/FBAN2HYNF4dmtTgq5tNfOAbaNym 0WPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=mcftJ0eL1AkWKzPlh7661CQAqOpZ/y4eLGeEn1Mnoik=; b=c74G5gUOcHkVHI8MXJg+N3ZOwpf2f7Yo80OS2WC2x0MGfAyZiw+rCOUND5aRdZ3q/7 u4UIjQj2IvC69WNCjfrSQFwziUTkfIo9OGfu4gtA6RvVUDTM6Yi8isjSf/ObYyCKvK9N nbgh8UvgPqdCyAD47zL0Pv4VkY5ktSHP/MBrZADx03uVUiJjlV7KevuoldsRGgAzInJM deeDC27F8qTKBzpa5xQVD659WD9mWEWrZhHZobcAxeCHlc9lRuoDjxt2ZmvlwShJRjMk twL6KpFzk9KMQAsxQhITepkCo2h8iMzgDvFg62CN5SJScIBlZxUEwWdM04bgPfQRzyna IU+A== X-Gm-Message-State: AOAM531u9OjQf6/q8NTfFlzEBcZjEoyPpTt7AlftYkbmIOToaM3UYW27 u8PMf4X/lppv0yO5fdZKFg2NWg== X-Google-Smtp-Source: ABdhPJzIMEmVjJ03EVYQd4J1PFX83FBdnM6BA+rshd+/soLwbKJ/DroiH1Rr+i21b3BG55nxfbzZlg== X-Received: by 2002:a17:902:bd04:b0:151:6cec:4b3 with SMTP id p4-20020a170902bd0400b001516cec04b3mr20715299pls.106.1646794124778; Tue, 08 Mar 2022 18:48:44 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:2d45:59c2:b66a:384a]) by smtp.gmail.com with ESMTPSA id m4-20020a17090a7f8400b001bef3fc3938sm431980pjl.49.2022.03.08.18.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 18:48:44 -0800 (PST) Date: Wed, 9 Mar 2022 11:48:39 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , Masami Hiramatsu , U-Boot Mailing List , Lukasz Majewski , Peng Fan , Bin Meng , Jaehoon Chung , Stefan Roese , Ilias Apalodimas Subject: Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model Message-ID: <20220309024839.GC136899@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Masami Hiramatsu , U-Boot Mailing List , Lukasz Majewski , Peng Fan , Bin Meng , Jaehoon Chung , Stefan Roese , Ilias Apalodimas References: <20220308113657.221101-1-takahiro.akashi@linaro.org> <82d88a69-159a-257d-2fcb-b6226bff6fe4@gmx.de> <20220309021006.GA136899@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Tue, Mar 08, 2022 at 07:34:15PM -0700, Simon Glass wrote: > Hi Takahiro, > > On Tue, 8 Mar 2022 at 19:10, AKASHI Takahiro wrote: > > > > Heinrich, Simon, > > > > On Tue, Mar 08, 2022 at 05:49:13PM +0100, Heinrich Schuchardt wrote: > > > On 3/8/22 12:36, AKASHI Takahiro wrote: > > > > With this patch set[1] applied, UEFI subsystem maintains a list of its > > > > disk objects dynamically at runtime based on block device's probing. > > > > (See "issues" below.) > > > > > > > > [1]https://github.com/t-akashi/u-boot/tree/efi/dm_disk > > > > > > This series together with Simon's series breaks multiple boards due to > > > size constraints: > > > > > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/11197 > > > > > > Please, investigate how to work around this issue. > > > > I have already mentioned this size issue in my cover-letter > > in order to let reviewers aware of it and discuss a possible solution: > > > > ===8<=== > > Issues: > > ======= > > * The image size of U-Boot may increase. CI build test complains, > > for instance, > > rcar3_salvator-x: > > "u-boot.img exceeds file size limit: ... excess: 0x79c bytes" > > phycore-rk3288: > > "SPL image is too large (size 0x8800 than 0x8000)" > > > > See [2]. > > > > [2] https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3770&view=results > > ===>8=== > > > > I have dug into rcar3_salvator-x case; I removed *all* the commits > > in this series and yet enabled CONFIG_EVENT, CONFIG_EVENT_DYNAMIC > > and CONFIG_DM_EVENT, which are all required for enabling my patch, > > with Simon's patch applied on top of v2022.04-rc3. > > > > Then I still see this size problem: > > ===8<=== > > ... > > MKIMAGE u-boot.img > > u-boot.img exceeds file size limit: > > limit: 0x100000 bytes > > actual: 0x100036 bytes > > excess: 0x36 bytes > > ===>8=== > > > > So I have no way to deal with it. > > > > FYI, the combination of EVENT, EVENT_DYNAMIC and DM_EVENT will > > increase the binary size by up to 0x1b2 for rcar3_salvator-x and > > it seems the binary has almost already reached its maximum size > > even now. > > So you do need EVENT_DYNAMIC? Unfortunately, yes. When I rebased my patch set to your v2, I tried to use *static* bindings, but some of ut tests, including dm_test_blk_base and dm_test_blk_usb, failed. This can happen because, with static bindings, efi's callback function (efi_disk_probe) is unconditionally called even when UEFI subsystem has not been initialized yet. -Takahiro Akashi > Does it make sense to make enabling the partition support an option, > instead of mandatory? > > Regards, > Simon