From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D06DC433F5 for ; Wed, 9 Mar 2022 09:55:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FAD9817D8; Wed, 9 Mar 2022 10:54:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="GLnZAxMJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3706782F5E; Wed, 9 Mar 2022 10:54:55 +0100 (CET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34ABB80331 for ; Wed, 9 Mar 2022 10:54:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clement.leger@bootlin.com Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 53806C0008; Wed, 9 Mar 2022 09:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646819690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NZ2Nft92+9ee25cyPMkKzFD2xjbx7MDVRQqh0Ybb5vk=; b=GLnZAxMJ3za4om5Q+qrxLOedIrCS93FvWS8MZm04OEttiwqltFo9v3Jr9kSQgNrL/suf7t wlmwZ+A+QC2f3ArAFz6ikGx94J5MFyoiMcVlXX+r/8dIVjw0T3Lgv24SW2zT+xT1WaQvnT tw2b5r2wOs8q0VasVn2vNGckNPmMabSj7UNLJgivcSZxaJFtHA62CbR6NH+DwTqtKbkwFn PS1HYf8G0Mz8I0x9PXDikGDNeJ+7U7Q/DJF499yhZBd9n3lqulis0KUBKw0E2WDaezeaF4 Z1ZLhS4GD0FLYJ3AQ61MoXFsBBEU/pscjnib/TU5vzpuCyyZtDs8zR/oHRAIng== Date: Wed, 9 Mar 2022 10:53:25 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Cc: , , , , Subject: Re: [PATCH v6 2/4] ARM: dts: at91: sama5d2: add AIC node Message-ID: <20220309105325.49b5b885@fixe.home> In-Reply-To: References: <20220309092259.76543-1-clement.leger@bootlin.com> <20220309092259.76543-3-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Le Wed, 9 Mar 2022 09:45:01 +0000, a =C3=A9crit : > On 3/9/22 11:22 AM, Cl=C3=A9ment L=C3=A9ger wrote: > > When using interrupts property, a global interrupt controller needs to > > be added to avoid warnings when compiling device-tree: > >=20 > > arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property): > > /ahb/apb/timer@f800c000: Missing interrupt-parent > >=20 > > Add AIC node as the sama5d2 global interrupt controller. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > arch/arm/dts/sama5d2.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > >=20 > > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi > > index 038cd73c03..1904f16eb6 100644 > > --- a/arch/arm/dts/sama5d2.dtsi > > +++ b/arch/arm/dts/sama5d2.dtsi > > @@ -3,6 +3,7 @@ > > / { > > model =3D "Atmel SAMA5D2 family SoC"; > > compatible =3D "atmel,sama5d2"; > > + interrupt-parent =3D <&aic>; > >=20 > > aliases { > > spi0 =3D &spi0; > > @@ -762,6 +763,15 @@ > > status =3D "disabled"; > > }; > >=20 > > + aic: interrupt-controller@fc020000 { > > + compatible =3D "atmel,sama5d2-aic"; > > + reg =3D <0xfc020000 0x200>; > > + #interrupt-cells =3D <3>; > > + interrupt-controller; > > + atmel,external-irqs =3D <49>; > > + status =3D "disabled"; > > + }; =20 >=20 > Hello Clement, >=20 > Any reason to not use the exact node from Linux ? I wanted it to match all the existing nodes that are already in this file (ie compatible, then regs and so on), it seems more coherent. >=20 > aic: interrupt-controller@fc020000 { > #interrupt-cells =3D <3>;=20 >=20 > compatible =3D "atmel,sama5d2-aic";=20 >=20 > interrupt-controller;=20 >=20 > reg =3D <0xfc020000 0x200>;=20 >=20 > atmel,external-irqs =3D <49>;=20 >=20 > }; >=20 > I would like to avoid any difference between Uboot and Linux, unless=20 > really required. If you want, I can reuse the exact same definition used by Linux of course. >=20 > Don't worry if the node is enabled, it's no problem with that. It won't=20 > be probed due to several reasons: no driver and no need for it, since=20 > Uboot is based on lazy probing. Ok. >=20 > Eugen >=20 > > + > > i2c1: i2c@fc028000 { > > compatible =3D "atmel,sama5d2-i2c"; > > reg =3D <0xfc028000 0x100>; > > -- > > 2.34.1 > > =20 >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com