Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model

Heinrich Schuchardt
2022-03-08T13:24:55Z

On 3/8/22 14:04, AKASHI Takahiro wrote:
> On Tue, Mar 08, 2022 at 01:59:08PM +0100, Heinrich Schuchardt wrote:
>> On 3/8/22 12:36, AKASHI Takahiro wrote:
>>> With this patch set[1] applied, UEFI subsystem maintains a list of its
>>> disk objects dynamically at runtime based on block device's probing.
>>> (See "issues" below.)
>>>
>>> [1] https://github.com/t-akashi/u-boot/tree/efi/dm_disk
>>
>> On sandbox_defconfig with CONFIG_EFI_SELFTEST=y I see this error which
>> does not occur without your patches:
>>
>> Executing 'load file protocol'
>> lib/efi_selftest/efi_selftest_load_file.c(220):
>> ERROR: Wrong remaining device path
>> lib/efi_selftest/efi_selftest_load_file.c(396):
>> ERROR: Failed to load image
>> lib/efi_selftest/efi_selftest.c(114):
>> ERROR: Executing 'load file protocol' failed

I missed to put Simon's event series first. With both series the error
vanishes.

Best regards

Heinrich

>>
>> Could you, please, check.
>
> I will, but I also request you to review *the code* itself.
>
> -Takahiro Akashi
>
>> Best regards
>>
>> Heinrich