public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Johannes Krottmayer <krjdev@gmail.com>
To: u-boot@lists.denx.de, trini@konsulko.com
Cc: Johannes Krottmayer <krjdev@gmail.com>
Subject: [PATCH 2/2] lib: time.c: Try also DM timer, when CONFIG_TIMER_EARLY is selected
Date: Thu, 10 Mar 2022 19:45:49 +0100	[thread overview]
Message-ID: <20220310184549.1883-3-krjdev@gmail.com> (raw)
In-Reply-To: <20220310184549.1883-1-krjdev@gmail.com>

Description:

When CONFIG_TIMER_EARLY is selected only the timer_early_* functions
will be called. With this patch first gd->timer will be checked, if the
DM timer is available, it uses the DM timer. When gd->timer is empty,
the timer_early_* functions will be called.

Signed-off-by: Johannes Krottmayer <krjdev@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
---
 lib/time.c | 46 ++++++++++++++++++++++++++++++++--------------
 1 file changed, 32 insertions(+), 14 deletions(-)

diff --git a/lib/time.c b/lib/time.c
index 96074b84af..85803d8ff5 100644
--- a/lib/time.c
+++ b/lib/time.c
@@ -5,7 +5,6 @@
  */
 
 #include <common.h>
-#include <clock_legacy.h>
 #include <bootstage.h>
 #include <dm.h>
 #include <errno.h>
@@ -66,17 +65,22 @@ extern unsigned long __weak timer_read_counter(void);
 #if CONFIG_IS_ENABLED(TIMER)
 ulong notrace get_tbclk(void)
 {
-	if (!gd->timer) {
+	int ret;
+
 #ifdef CONFIG_TIMER_EARLY
+	if (!gd->timer)
 		return timer_early_get_rate();
+
+	ret = dm_timer_init();
+
+	if (ret)
+		return ret;
 #else
-		int ret;
+	ret = dm_timer_init();
 
-		ret = dm_timer_init();
-		if (ret)
-			return ret;
+	if (ret)
+		return ret;
 #endif
-	}
 
 	return timer_get_rate(gd->timer);
 }
@@ -86,19 +90,32 @@ uint64_t notrace get_ticks(void)
 	u64 count;
 	int ret;
 
-	if (!gd->timer) {
 #ifdef CONFIG_TIMER_EARLY
+	if (!gd->timer)
 		return timer_early_get_count();
-#else
-		int ret;
 
-		ret = dm_timer_init();
-		if (ret)
-			panic("Could not initialize timer (err %d)\n", ret);
-#endif
+	ret = dm_timer_init();
+
+	if (ret)
+		panic("Could not initialize timer (err %d)\n", ret);
+
+	ret = timer_get_count(gd->timer, &count);
+
+	if (ret) {
+		if (spl_phase() > PHASE_TPL)
+			panic("Could not read count from timer (err %d)\n",
+			      ret);
+		else
+			panic("no timer (err %d)\n", ret);
 	}
+#else
+	ret = dm_timer_init();
+
+	if (ret)
+		panic("Could not initialize timer (err %d)\n", ret);
 
 	ret = timer_get_count(gd->timer, &count);
+
 	if (ret) {
 		if (spl_phase() > PHASE_TPL)
 			panic("Could not read count from timer (err %d)\n",
@@ -106,6 +123,7 @@ uint64_t notrace get_ticks(void)
 		else
 			panic("no timer (err %d)\n", ret);
 	}
+#endif
 
 	return count;
 }
-- 
2.34.1


  parent reply	other threads:[~2022-03-10 18:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 18:45 [PATCH 0/2] CONFIG_EARLY_TIMER: Fix EAGAIN issue and use DM too Johannes Krottmayer
2022-03-10 18:45 ` [PATCH 1/2] common: board_f.c: Fix EAGAIN issue when CONFIG_TIMER_EARLY is selected Johannes Krottmayer
2022-03-11 16:35   ` Johannes (krjdev) Krottmayer
2022-03-10 18:45 ` Johannes Krottmayer [this message]
2022-03-11 16:34   ` [PATCH 2/2] lib: time.c: Try also DM timer, " Johannes (krjdev) Krottmayer
2022-03-11 16:35 ` [PATCH 0/2] CONFIG_EARLY_TIMER: Fix EAGAIN issue and use DM too Johannes (krjdev) Krottmayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310184549.1883-3-krjdev@gmail.com \
    --to=krjdev@gmail.com \
    --cc=krjdev@gnail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox