From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BCDFC433EF for ; Fri, 11 Mar 2022 13:52:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 65B22837F6; Fri, 11 Mar 2022 14:52:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HRuD/wRS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0C19C83093; Fri, 11 Mar 2022 14:52:21 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D04AF83836 for ; Fri, 11 Mar 2022 14:52:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id s15so7286217qtk.10 for ; Fri, 11 Mar 2022 05:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cAv+bkleEYeV7NSWs1TJBZtL/P9QAC0j3VcTspQUeLM=; b=HRuD/wRSQnsPPEYOn/I4daAJasyBWWKTMakdeVuLWUZNdmmDQNhpvGkjdDRKzTYBRn e/crRCsqE5rphPUuMCySZc4IVn9tiUxCSs7t0uGPZqHpOJbRoS0MQVK6xuJT3GUWimlw 5oQVxHXM18obvR1vMdEq/3sLDuV9NL9N6pBFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cAv+bkleEYeV7NSWs1TJBZtL/P9QAC0j3VcTspQUeLM=; b=PxsQFs3SfNDeRehPQeLrwvrK+6mQxpqFreaAD5B5MLv7/ZkmbeEWlGJzgNQYrdPF4e 7i5p4klXSiwCPKuWGIkQvTixd4GlK7QjwulpktGbJuKTBuolo+Dt8ugGZ5Xn/a7NjTDC j+qcM3Pf36a5hk7X7QueNcu5/cJo9NXasYXuS1fC8WM9rRuP99Z/Jv2Ex+jV5ow8ECJB tbO1d2iG27EDHjwjJtq3ldSCGImwGsDCqL3+yuvyHgwPx3gnhJBxmhI3uUsOaFgjelPc FQzPA5XFJHfXD7i5x+k6yQ+hPGe6FsekrR8/7rDLjgMnYt0ov79SR+oeKB4SnvWuMrtg q5nA== X-Gm-Message-State: AOAM531epnN9t1dx1w+yjpTjcbphQ0IT6TeMUZjkvbnojZHL+TntajwX yBP2JCl4240m9xcxd7I7D6WisQ== X-Google-Smtp-Source: ABdhPJzPwDSheh2djSEqQahYow+nLcC+H6EQrgQH/9KvMAWMmm8NtgKW/j8IFvMcbuCVZOXeEsSq8Q== X-Received: by 2002:a05:622a:1905:b0:2e0:7543:21d4 with SMTP id w5-20020a05622a190500b002e0754321d4mr8444145qtc.12.1647006730460; Fri, 11 Mar 2022 05:52:10 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id x5-20020ae9e645000000b0067b122fae88sm3842476qkl.2.2022.03.11.05.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 05:52:09 -0800 (PST) Date: Fri, 11 Mar 2022 08:52:07 -0500 From: Tom Rini To: Lukasz Majewski Cc: u-boot@lists.denx.de, Andre Przywara , Enric Balletbo i Serra , Govindaraji Sivanantham , Hannes Schmelzer , Heiko Schocher , Hiremath Gireesh , Jaehoon Chung , Marcin Niestroj , Marek =?iso-8859-1?Q?Beh=FAn?= , Patrick Delaunay , Priyanka Jain , Quentin Schulz , Rick Chen , Samuel Holland , Simon Glass , Sjoerd Simons , Stefan Roese , Stephan Gerhold Subject: Re: [PATCH 1/3] power: Rename CONFIG_POWER_TPS65217 with CONFIG_PMIC_TPS65217 Message-ID: <20220311135207.GS5020@bill-the-cat> References: <20220222080401.6859-1-lukma@denx.de> <20220310185205.GA1949208@bill-the-cat> <20220311130908.70725c76@ktm> <20220311121634.GR5020@bill-the-cat> <20220311143545.62227480@ktm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O5SrAdi84GtkM3Hw" Content-Disposition: inline In-Reply-To: <20220311143545.62227480@ktm> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --O5SrAdi84GtkM3Hw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 11, 2022 at 02:35:45PM +0100, Lukasz Majewski wrote: > Hi Tom, >=20 > > On Fri, Mar 11, 2022 at 01:09:08PM +0100, Lukasz Majewski wrote: > > > Hi Tom, > > > =20 > > > > On Tue, Feb 22, 2022 at 09:03:58AM +0100, Lukasz Majewski wrote: = =20 > > > > > Up till now the CONFIG_POWER_TPS65217 has been defined in > > > > > several header files for am335x SoC. > > > > >=20 > > > > > This patch renames it to CONFIG_PMIC_TPS65217, which better > > > > > reflects the role of this IC circuit. > > > > >=20 > > > > > Signed-off-by: Lukasz Majewski > > > > > Reviewed-by: Jaehoon Chung > > > > > --- > > > > >=20 > > > > > drivers/power/pmic/Makefile | 2 +- > > > > > include/configs/am335x_evm.h | 2 +- > > > > > include/configs/am335x_guardian.h | 2 +- > > > > > include/configs/am335x_shc.h | 2 +- > > > > > include/configs/am335x_sl50.h | 2 +- > > > > > include/configs/brppt1.h | 2 +- > > > > > include/configs/bur_am335x_common.h | 2 +- > > > > > include/configs/chiliboard.h | 2 +- > > > > > scripts/config_whitelist.txt | 2 +- > > > > > 9 files changed, 9 insertions(+), 9 deletions(-) =20 > > > >=20 > > > > This needs to be migrated to Kconfig fully / correctly as well, > > > > not just changing the whitelist entry. > > > > =20 > > >=20 > > > But there is follow up patch, which adds proper entry to Kconfig > > > with new name: > > >=20 > > > https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-= 2-lukma@denx.de/ > > >=20 > > > The idea was to first rename the CONFIG_POWER_TPS65217 to > > > CONFIG_PMIC_TPS65217 (as a single patch) and then provide DM support > > > for TPS65217 with proper (renamed) Kconfig entry. =20 > >=20 > > Please re-order the series so we don't do what you're doing here and > > be sure to fully migrate everyone. I noticed this as part of finding > > and fixing: > > https://patchwork.ozlabs.org/project/uboot/patch/20220311121248.2801589= -1-trini@konsulko.com/ > > yesterday and saw a bunch of PMIC symbols get listed. > >=20 >=20 > I can squash those two patches: > https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-1-lu= kma@denx.de/ > https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-2-lu= kma@denx.de/ >=20 > However, the drawback is that we would have the move to Kconfig type of > patch with the rename. >=20 > Would it be OK? Yes, that's fine. And some patches to migrate other CONFIG.*POWER.* symbols would be much appreciated too. --=20 Tom --O5SrAdi84GtkM3Hw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIrVAQACgkQFHw5/5Y0 tyxuGwv/T+W9fqxVOXP/6jMPzC/5KQ6n0LNEDYXe0/o2jWNQgUMVCsnTbWjpLMyc VJWz/+f+vlPuZsUROSB0zqtPEXkNFDVmHExKbEs4boKfNqxHELQKyu6vV2ZSqixD u4rydUZwK5xGIbKicbl8KwMuspUuwNTU027vLrIMq58+IFa/o6ftde0kR8PQp+CE PwsXKf0ynyCozEHwfkS++QxtphRyChJ6iWLWelInVfz/LBVbUTcdzAtZ7JNHRewQ L/KGSrMs+w5SueJPHu7xNapxsNAiuNS89byI85YuCfl0NgVYyTFziIzJLabRmZbJ AVpuO+KE/37ottmVs6kqce/7jD/KgvZ1X1c1LJnIpZZnUD07xFIJoO+uw2fkzrQP mfAe8n7m+VG/RM2+RUngUWV0RuzTd+fHRasSFxRRBB9NdrezKrAdy+VlVdc6u9wl Y4ZsKrW6RQjJm6TY2E+LVoznu+vCMsHI3zkNlPDIQ5dDdjGa+tA6NkhcIAk48xmq Es8PvLlR =Dack -----END PGP SIGNATURE----- --O5SrAdi84GtkM3Hw--