From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C46E1C433EF for ; Fri, 11 Mar 2022 13:35:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2D4F983A2B; Fri, 11 Mar 2022 14:35:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647005753; bh=9IVGMlp3iQFvI4i1IwBICjj9EON5yQH3brkAnHLK5VQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AuAIrNi2OeW6daD7pnJSGVcRFJYwld+V8xcPC5BGqrDG6Atbrevc5/bm55CwuJLPL 05Zkj877DzD8cjcnpeMuMCRXTV65zHEW6B3yJWPvQAuc77430sfC83KDzDZuJSAEdU IYOVGEj3VcnxgMzmPUk1KMdIGV5dMqjeb1RhrHm0IXd3NyjEX/Tc0wGQ1q+v7U3ibl yu8jSrxP4IgeVkhKZtCBkycoMF4ywSB9+8ykRjFViaKNDjYrslWodRIod4BJ7BExFE 0m/wWuJGnw9vS1WIJgj2NzyiRYzVTLrUIWkcqrWTXJDr7OvBKHu6zwVzPMH2MjobkV V2285Ye0ik4TQ== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7480A837EF; Fri, 11 Mar 2022 14:35:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647005750; bh=9IVGMlp3iQFvI4i1IwBICjj9EON5yQH3brkAnHLK5VQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iCsaRE299vft/BHyae597CN6BbNmts1NkXJ1dSvStDmjyrNUTNsvnHl1NuHOPYbJI MrCwK8psts6BHiPxXlJ0c4D7BADg5yWEjpE+vNIyDFCWIruChTvkMGKSBDumG1xuc/ nXtDoZGyO/6hUjyr1e7zTPUwWAPOlagBc5tFDddAXa1hJC5nVb926d8amz3diPDMOc UbImYNX/ZWYEtBntKmnOAQiZIMvRTD7WZjOiUNZIYSbDpwDXh8LcgtnxbBdRqADSoP ySMrGzIRxtpyt9eoNP5jKiOYGr5vgHxvlAweGCsyuj8WS4+xPt00OxusgI/KuxjIHi ZkzII4qwtStBg== Date: Fri, 11 Mar 2022 14:35:45 +0100 From: Lukasz Majewski To: Tom Rini Cc: u-boot@lists.denx.de, Andre Przywara , Enric Balletbo i Serra , Govindaraji Sivanantham , Hannes Schmelzer , Heiko Schocher , Hiremath Gireesh , Jaehoon Chung , Marcin Niestroj , Marek =?UTF-8?B?QmVow7pu?= , Patrick Delaunay , Priyanka Jain , Quentin Schulz , Rick Chen , Samuel Holland , Simon Glass , Sjoerd Simons , Stefan Roese , Stephan Gerhold Subject: Re: [PATCH 1/3] power: Rename CONFIG_POWER_TPS65217 with CONFIG_PMIC_TPS65217 Message-ID: <20220311143545.62227480@ktm> In-Reply-To: <20220311121634.GR5020@bill-the-cat> References: <20220222080401.6859-1-lukma@denx.de> <20220310185205.GA1949208@bill-the-cat> <20220311130908.70725c76@ktm> <20220311121634.GR5020@bill-the-cat> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/L2ug4TyLMVq8S727cE4UMm7"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --Sig_/L2ug4TyLMVq8S727cE4UMm7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Tom, > On Fri, Mar 11, 2022 at 01:09:08PM +0100, Lukasz Majewski wrote: > > Hi Tom, > > =20 > > > On Tue, Feb 22, 2022 at 09:03:58AM +0100, Lukasz Majewski wrote: =20 > > > > Up till now the CONFIG_POWER_TPS65217 has been defined in > > > > several header files for am335x SoC. > > > >=20 > > > > This patch renames it to CONFIG_PMIC_TPS65217, which better > > > > reflects the role of this IC circuit. > > > >=20 > > > > Signed-off-by: Lukasz Majewski > > > > Reviewed-by: Jaehoon Chung > > > > --- > > > >=20 > > > > drivers/power/pmic/Makefile | 2 +- > > > > include/configs/am335x_evm.h | 2 +- > > > > include/configs/am335x_guardian.h | 2 +- > > > > include/configs/am335x_shc.h | 2 +- > > > > include/configs/am335x_sl50.h | 2 +- > > > > include/configs/brppt1.h | 2 +- > > > > include/configs/bur_am335x_common.h | 2 +- > > > > include/configs/chiliboard.h | 2 +- > > > > scripts/config_whitelist.txt | 2 +- > > > > 9 files changed, 9 insertions(+), 9 deletions(-) =20 > > >=20 > > > This needs to be migrated to Kconfig fully / correctly as well, > > > not just changing the whitelist entry. > > > =20 > >=20 > > But there is follow up patch, which adds proper entry to Kconfig > > with new name: > >=20 > > https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-2-= lukma@denx.de/ > >=20 > > The idea was to first rename the CONFIG_POWER_TPS65217 to > > CONFIG_PMIC_TPS65217 (as a single patch) and then provide DM support > > for TPS65217 with proper (renamed) Kconfig entry. =20 >=20 > Please re-order the series so we don't do what you're doing here and > be sure to fully migrate everyone. I noticed this as part of finding > and fixing: > https://patchwork.ozlabs.org/project/uboot/patch/20220311121248.2801589-1= -trini@konsulko.com/ > yesterday and saw a bunch of PMIC symbols get listed. >=20 I can squash those two patches: https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-1-lukm= a@denx.de/ https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-2-lukm= a@denx.de/ However, the drawback is that we would have the move to Kconfig type of patch with the rename. Would it be OK? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/L2ug4TyLMVq8S727cE4UMm7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmIrUDEACgkQAR8vZIA0 zr0N5Qf/UupHoGqkVtxTn0cvsaXAPpAVzSt8omO2bH0nQ2qSllYHZFN7i6rSMfkA MwEiEHDf9+E7+G5tgIiHGBU9YSFwuZSP//DfL34idwz5lMU6a0J2dAz2S4hW7x0v FINmiPCGcrqYfH+wth/Fq4Lu4BaQFNof8CyVSNFEEaRcrEpFyxIZoa+KRbxDipyi xqha7adOORfZymWSxJlY9YJd35DXWy3WhFZq17mptavGzWmXNxZoRcOCVs1H6nH0 Te0/gZYS3joqJq/mkfkQWCLimeyUlJeQDVzh0KxUZxbI64B0/MsVG5juvJDPgDTH 6n3ejIQNZgYCAMq10hwdkwvy7VrC1w== =RunA -----END PGP SIGNATURE----- --Sig_/L2ug4TyLMVq8S727cE4UMm7--