Re: [PATCH 1/3] power: Rename CONFIG_POWER_TPS65217 with CONFIG_PMIC_TPS65217

Lukasz Majewski
2022-03-11T13:35:55Z

[-- Attachment #1: Type: text/plain, Size: 2542 bytes --]

Hi Tom,

> On Fri, Mar 11, 2022 at 01:09:08PM +0100, Lukasz Majewski wrote:
> > Hi Tom,
> >
> > > On Tue, Feb 22, 2022 at 09:03:58AM +0100, Lukasz Majewski wrote:
> > > > Up till now the CONFIG_POWER_TPS65217 has been defined in
> > > > several header files for am335x SoC.
> > > >
> > > > This patch renames it to CONFIG_PMIC_TPS65217, which better
> > > > reflects the role of this IC circuit.
> > > >
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> > > > ---
> > > >
> > > > drivers/power/pmic/Makefile | 2 +-
> > > > include/configs/am335x_evm.h | 2 +-
> > > > include/configs/am335x_guardian.h | 2 +-
> > > > include/configs/am335x_shc.h | 2 +-
> > > > include/configs/am335x_sl50.h | 2 +-
> > > > include/configs/brppt1.h | 2 +-
> > > > include/configs/bur_am335x_common.h | 2 +-
> > > > include/configs/chiliboard.h | 2 +-
> > > > scripts/config_whitelist.txt | 2 +-
> > > > 9 files changed, 9 insertions(+), 9 deletions(-)
> > >
> > > This needs to be migrated to Kconfig fully / correctly as well,
> > > not just changing the whitelist entry.
> > >
> >
> > But there is follow up patch, which adds proper entry to Kconfig
> > with new name:
> >
> > https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-2-lukma@denx.de/
> >
> > The idea was to first rename the CONFIG_POWER_TPS65217 to
> > CONFIG_PMIC_TPS65217 (as a single patch) and then provide DM support
> > for TPS65217 with proper (renamed) Kconfig entry.
>
> Please re-order the series so we don't do what you're doing here and
> be sure to fully migrate everyone. I noticed this as part of finding
> and fixing:
> https://patchwork.ozlabs.org/project/uboot/patch/20220311121248.2801589-1-trini@konsulko.com/
> yesterday and saw a bunch of PMIC symbols get listed.
>

I can squash those two patches:
https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-1-lukma@denx.de/
https://patchwork.ozlabs.org/project/uboot/patch/20220222080401.6859-2-lukma@denx.de/

However, the drawback is that we would have the move to Kconfig type of
patch with the rename.

Would it be OK?

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]