From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0E57C433F5 for ; Sun, 13 Mar 2022 11:06:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6499E81E0C; Sun, 13 Mar 2022 12:06:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="eqbP5mUA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F214182DD7; Sun, 13 Mar 2022 12:06:46 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 61D9A8191C for ; Sun, 13 Mar 2022 12:06:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EE1E60FFA; Sun, 13 Mar 2022 11:06:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A248C340E8; Sun, 13 Mar 2022 11:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647169598; bh=U6K8naLJKJ1e28PA0NcgwKf+fGA82LCfQoCMSSwz6/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eqbP5mUAgSlVFtqTCeDF9onXQWo9urByePlLY9c77CmjSZyeo7OUSThdEdrHPloiX 3/L5SES9dBq9NCoD5lqgEoQn5CeKaexdvnbWKHoQuDo90xtW/jAMd4a6sObfwJAS9q 8C4tY1n8TDjwlI1V/t8MrCfVXnAbHx/BkZYmwkmS/bLyQYCIcbp04mhRnm/BsZAwgv Kd8Y8fwmMH4rFFAuUh9/dGMO4S4Mx+6rgWHZgD9ZSml1e17ADurizoIWY9H/ZzfsFx PHYYz3/KG+tNgT9TILzkkSTMo42ZgaVJn4WuSLBeepwW57FpuE/PY36Ucv5i0HQ3Bo Xxrj7dhjvy39A== Received: by pali.im (Postfix) id F11FFB6E; Sun, 13 Mar 2022 12:06:35 +0100 (CET) Date: Sun, 13 Mar 2022 12:06:35 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Anatolij Gustschin , Tom Rini , U-Boot Mailing List Subject: Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO Message-ID: <20220313110635.p6mnafg53ucafkry@pali> References: <20220306115141.gb4y6fsgqmrtg4ce@pali> <20220306141706.k3vfxd4bhzth6duy@pali> <20220306152540.nom7dernmwqctbdd@pali> <20220309194450.ilqjv44lx7jbkmyl@pali> <20220309232011.01982cec@crub> <20220311185816.zpswpbkpii52hllg@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Friday 11 March 2022 22:02:39 Simon Glass wrote: > Hi Pali, > > On Fri, 11 Mar 2022 at 11:58, Pali Rohár wrote: > > > > On Wednesday 09 March 2022 23:20:11 Anatolij Gustschin wrote: > > > Hi Pali, > > > > > > On Wed, 9 Mar 2022 20:44:50 +0100 > > > Pali Rohár pali@kernel.org wrote: > > > > > > > On Sunday 06 March 2022 11:44:22 Simon Glass wrote: > > > > > Hi Pali, > > > > > > > > > > On Sun, 6 Mar 2022 at 08:25, Pali Rohár wrote: > > > > > > > > > > > > On Sunday 06 March 2022 07:42:03 Simon Glass wrote: > > > > > > > Yes let's go with that. > > > > > > > > > > > > Done, I sent final version of the patch. > > > > > > > > > > > > > > > > > > > Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it > > > > > > > > > > > > > is enabled in config file. I do not know why too. > > > > > > > > > > > > > > > > > > > > > > > > > > Any idea? > > > > > > > > > > > > > > > > > > > > > > > > Not yet. There were some logo related changes recently, but if I > > > > > > > > > > > > remember correctly, I tested them on wandboard and nitrogen6q > > > > > > > > > > > > targets and with sandbox, and logo drawing worked there. > > > > > > > > > > > > > > > > > > Can you be more specific than 'broken'? What is broken about it? > > > > > > > > > > > > > > > > Does not work, logo is not drown on the screen. > > > > > > > > > > > > > > See video_bmp_display() - I wonder if the particular depth you are > > > > > > > using is not supported? > > > > > > > > > > > > Depth is 16bit which should be supported. > > > > > > > > > > But apparently isn't , at least in this case :-) > > > > > > > > Yea, something is broken there. > > > > > > > > > > > > > > > > > Anyway you should be able to debug it there or > > > > > > > using the bmp command. The file is drivers/video/u_boot_logo.bmp > > > > > > > > > > > > CONFIG_CMD_BMP=y is broken too. When I enable it then U-Boot freeze > > > > > > after the line 'Loading Environment from ... OK'. > > > > > > > > > > OK I'm not sure why, but please investigate if you have time. > > > > > > > > I have looked at it and do not know. But probably it is because I > > > > somehow have not caught how this new video code works... > > > > > > > > Anyway, I sent documentation update how to run u-boot for n900 in qemu: > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220308175956.4522-1-pali@kernel.org/ > > > > > > > > So it could help other people to look at issues which do not work > > > > correctly in n900's u-boot without need to have n900 hardware. > > > > > > I've tested your v2 patches, and logo drawing works, but the logo > > > appears for short time. Then it is later overwritten by boot menu. > > > > > > -- > > > Anatolij > > > > Hello! Thank you for checking. It is possible that qemu rending is > > slower and reason why I did not see any logo. > > > > Anyway, this is now how CONFIG_VIDEO_LOGO worked. In previous U-Boot > > version it drew logo on the screen and it was visible also in the boot > > menu. > > > > Any idea what was changed? Or is there missing some another config > > option to make logo visible? > > I believe the cfb_console code had a way to keep the logo at the top > with the text scrolling underneath. This has not been implemented in > the video/vidconsole uclasses, although I suppose it could be. > > Regards, > Simon Ok!