From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 14/18] Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE
Date: Mon, 14 Mar 2022 10:59:23 +0900 [thread overview]
Message-ID: <20220314015923.GB37492@laputa> (raw)
In-Reply-To: <CAPnjgZ2Ndhma49hVXORog9_=4G-+Hn5c7=pPW7YEC7kigbFFEg@mail.gmail.com>
Hi Simon,
On Fri, Mar 11, 2022 at 07:25:16PM -0700, Simon Glass wrote:
> Hi Takahiro,
>
> On Mon, 28 Feb 2022 at 21:22, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
> >
> > Simon,
> >
> > On Mon, Feb 28, 2022 at 12:08:31PM -0700, Simon Glass wrote:
> > > Add this dependency to avoid a build error if FIT_SIGNATURE is not
> > > enabled.
> >
> > I doubt it.
> > With qemu_arm64_defconfig & ASYMMETRIC_KEY_TYPE & !FIT_SIGNATURE,
> > I don't see any build error on 2022.04-rc2.
>
> This is what I see when building sandbox with Chromium OS verified
> boot (where FIT_SIGNATURE is not enabled).
>
> /usr/bin/ld: lib/crypto/public_key.o: in function `public_key_verify_signature':
> lib/crypto/public_key.c:113: undefined reference to `image_get_padding_algo'
> /usr/bin/ld: lib/crypto/public_key.c:124: undefined reference to
> `image_get_checksum_algo'
> /usr/bin/ld: lib/crypto/public_key.c:126: undefined reference to
> `image_get_crypto_algo'
After my commit b983cc2da0ba ("lib: rsa: decouple rsa from FIT image
verification"), those symbols are independently compiled in
with CONFIG_IMAGE_SIGN_INFO.
> /usr/bin/ld: lib/crypto/public_key.c:136: undefined reference to
> `rsa_verify_with_pkey'
Likewise, please select CONFIG_RSA_VERIFY_WITH_PKEY specifically
instead of CONFIG_FIT_SIGNATURE.
-Takahiro Akashi
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:1901: u-boot] Error 1
>
>
> Regards,
> Simon
> [..]
next prev parent reply other threads:[~2022-03-14 1:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 19:08 [PATCH 00/18] Various bugfixes related to verified boot Simon Glass
2022-02-28 19:08 ` [PATCH 01/18] buildman: Update default config to build for sandbox Simon Glass
2022-04-07 13:50 ` Tom Rini
2022-02-28 19:08 ` [PATCH 02/18] buildman: Fix up cfgutil Simon Glass
2022-02-28 19:08 ` [PATCH 03/18] binman: Correct Chromium OS entry types Simon Glass
2022-02-28 19:08 ` [PATCH 04/18] errno: Avoid including strings in SPL Simon Glass
2022-02-28 19:08 ` [PATCH 05/18] abuf: Correct a corner case with abuf_realloc() Simon Glass
2022-02-28 19:08 ` [PATCH 06/18] fdt: Correct condition for SEPARATE_BSS Simon Glass
2022-02-28 19:08 ` [PATCH 07/18] fdt: sandbox: Avoid looking for an appended device tree Simon Glass
2022-02-28 19:08 ` [PATCH 08/18] lzma: Tidy up the function prototype Simon Glass
2022-02-28 19:08 ` [PATCH 09/18] cbfs: Add some more definititions Simon Glass
2022-02-28 19:08 ` [PATCH 10/18] cros_ec: Complete the comment for cros_ec_read_batt_charge() Simon Glass
2022-02-28 19:08 ` [PATCH 11/18] spi: Avoid checking console in SPL Simon Glass
2022-02-28 19:08 ` [PATCH 12/18] disk: Correct the conditions for SPL Simon Glass
2022-02-28 19:08 ` [PATCH 13/18] Add a default for TPL_TEXT_BASE Simon Glass
2022-02-28 19:08 ` [PATCH 14/18] Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE Simon Glass
2022-03-01 4:22 ` AKASHI Takahiro
2022-03-12 2:25 ` Simon Glass
2022-03-14 1:59 ` AKASHI Takahiro [this message]
2022-02-28 19:08 ` [PATCH 15/18] stdint: Add a definition of UINT8_MAX Simon Glass
2022-02-28 19:08 ` [PATCH 16/18] dm: core: Add a required struct declaration Simon Glass
2022-02-28 19:08 ` [PATCH 17/18] dm: core: Tidy up comments in uclass headers Simon Glass
2022-02-28 19:08 ` [PATCH 18/18] dm: blk: Expand iteration and add tests Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314015923.GB37492@laputa \
--to=takahiro.akashi@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox