From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B7E6C433EF for ; Mon, 14 Mar 2022 01:59:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6FA883B57; Mon, 14 Mar 2022 02:59:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="zRX560P4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9E0883B63; Mon, 14 Mar 2022 02:59:32 +0100 (CET) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F1C4183B4A for ; Mon, 14 Mar 2022 02:59:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62c.google.com with SMTP id w4so12259431ply.13 for ; Sun, 13 Mar 2022 18:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=CPdM6NiLLW4LMzf/8ulO6pwsUNNQlGzoRxdAcZ/d1gU=; b=zRX560P4E4kR/zDJBOU8J6qSPh7wOI309KgJ+W4TbAqtidu6gaTY5jcD13sjK/1MOs cG0Ha+xbw9Ykw3Zwto8dxXt9KsotGZfOSZFORtJU9UHOuRqQn/x+3HW8215FS/6GwCEO ryIJm/xB5orxb5qj8Pp6fu6aZKb4UNVrS3AYzjPRh7MM2VXvyKWaq8NW8MawaKnQYN48 6jFm9PfGSiXk71tmDlac4nw7aIWuCNJa45Js2hqzAmziIwhAgj3J2qSNzs6MlasPcgOD fJuutSqNir6wemL1yVS+I3eZalIX6k0uxae6dr0tmnegb2NT4kNZKiuZVVePkFJe3sEI ogVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=CPdM6NiLLW4LMzf/8ulO6pwsUNNQlGzoRxdAcZ/d1gU=; b=NBvHtdJ1WhszBr3T1a8tj/uQH9pmZ2t/pEcTL3U2s/yt3Ckfn/uTxYamlJ/vSc541e rMjqXQMcvM3TJUqTGM+K9f3ZDlZSbZgpWZNxRv5DAIKmrgUhdzHBope6b/NmAo3avR8w wkMMKe4gylSTToMAg1kDNk14+ggLaZEjNnAWrnYQOlZRfzOkeOh4T++S0wJ6Qq4lZISY zRwztmyIKlgZx4G+q9bW9Lc1zViEN5Ksj0VrArzd9o1ih3sx2o0YWo/LDki34RTSpT5Z ncuTKJ2usFwg3LAUDBpnSule7as9S1NAn6F0ZqMlEvFR+jiuya91nZCFvP6SzfG9K+uY iUag== X-Gm-Message-State: AOAM533SBKQIfPnHFZ5P014UxNMw+hHR70uwRIQPZX/TpMlTYZFoCB7m O5yMFc9vJCJmybpP/Jg0TmaMOA== X-Google-Smtp-Source: ABdhPJzP0MP8+194LuHmFUJB3yqAluK8eTKiJvRuJIyZlBL8DKeYNl4+Takxua1zi1OfW8QT0YH9og== X-Received: by 2002:a17:90a:6508:b0:1be:d59c:1f10 with SMTP id i8-20020a17090a650800b001bed59c1f10mr22607350pjj.229.1647223167372; Sun, 13 Mar 2022 18:59:27 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:69ab:dc6d:d6e2:371d]) by smtp.gmail.com with ESMTPSA id p15-20020a056a000b4f00b004f7b71f8bd6sm4417352pfo.47.2022.03.13.18.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Mar 2022 18:59:27 -0700 (PDT) Date: Mon, 14 Mar 2022 10:59:23 +0900 From: AKASHI Takahiro To: Simon Glass Cc: U-Boot Mailing List , Tom Rini Subject: Re: [PATCH 14/18] Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE Message-ID: <20220314015923.GB37492@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , U-Boot Mailing List , Tom Rini References: <20220228190835.1480772-1-sjg@chromium.org> <20220228190835.1480772-15-sjg@chromium.org> <20220301042247.GA80958@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Fri, Mar 11, 2022 at 07:25:16PM -0700, Simon Glass wrote: > Hi Takahiro, > > On Mon, 28 Feb 2022 at 21:22, AKASHI Takahiro > wrote: > > > > Simon, > > > > On Mon, Feb 28, 2022 at 12:08:31PM -0700, Simon Glass wrote: > > > Add this dependency to avoid a build error if FIT_SIGNATURE is not > > > enabled. > > > > I doubt it. > > With qemu_arm64_defconfig & ASYMMETRIC_KEY_TYPE & !FIT_SIGNATURE, > > I don't see any build error on 2022.04-rc2. > > This is what I see when building sandbox with Chromium OS verified > boot (where FIT_SIGNATURE is not enabled). > > /usr/bin/ld: lib/crypto/public_key.o: in function `public_key_verify_signature': > lib/crypto/public_key.c:113: undefined reference to `image_get_padding_algo' > /usr/bin/ld: lib/crypto/public_key.c:124: undefined reference to > `image_get_checksum_algo' > /usr/bin/ld: lib/crypto/public_key.c:126: undefined reference to > `image_get_crypto_algo' After my commit b983cc2da0ba ("lib: rsa: decouple rsa from FIT image verification"), those symbols are independently compiled in with CONFIG_IMAGE_SIGN_INFO. > /usr/bin/ld: lib/crypto/public_key.c:136: undefined reference to > `rsa_verify_with_pkey' Likewise, please select CONFIG_RSA_VERIFY_WITH_PKEY specifically instead of CONFIG_FIT_SIGNATURE. -Takahiro Akashi > collect2: error: ld returned 1 exit status > make[1]: *** [Makefile:1901: u-boot] Error 1 > > > Regards, > Simon > [..]