Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

Tom Rini
2022-03-06T13:58:47Z

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Sun, Mar 06, 2022 at 12:50:24PM +0100, Pali Rohár wrote:
> On Friday 21 January 2022 16:21:33 Tom Rini wrote:
> > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote:
> >
> > > If image backend provides verify_header callback then call it after writing
> > > image to disk. This ensures that written image is correct.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > Reviewed-by: Stefan Roese <sr@denx.de>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > ---
> > > tools/mkimage.c | 41 +++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 41 insertions(+)
> >
> > This breaks a number of platforms such as ls1021atwr_sdcard_qspi and
> > it's not clear to me why exactly.
>
> Hello Tom! Is something still blocking this change?

Nope, thanks for the reminder.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]