Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On Mon, Mar 14, 2022 at 06:37:02PM +0900, Jaehoon Chung wrote:
> On 3/12/22 03:14, Robert Marko wrote:
> > Generic SDHCI driver received support for checking the busy status by
> > polling the DAT[0] level instead of waiting for the worst MMC switch time.
> > 
> > Unfortunately, it appears that this does not work for Xenon controllers
> > despite being a part of the standard SDHCI registers and the Armada 3720
> > datasheet itself telling that BIT(20) is useful for detecting the DAT[0]
> > busy signal.
> > 
> > I have tried increasing the timeout value, but I have newer managed to
> > catch DAT_LEVEL bits change from 0 at all.
> > 
> > This issue appears to hit most if not all SoC-s supported by Xenon driver,
> > at least A3720, A8040 and CN9130 have non working eMMC currently.
> > 
> > So, until a better solution is found drop the wait_dat0 OP for Xenon.
> > I was able to only test it on A3720, but it should work for others as well.
> > 
> > Fixes: 40e6f52454fc ("drivers: mmc: Add wait_dat0 support for sdhci driver")
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> 
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Since this is a regression fix, will this be in the PR with the imx fix
as well?  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]