From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42472C433F5 for ; Mon, 14 Mar 2022 19:38:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47AC283B84; Mon, 14 Mar 2022 20:38:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="T9dGaLQh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A32C83282; Mon, 14 Mar 2022 20:38:52 +0100 (CET) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6DED83B90 for ; Mon, 14 Mar 2022 20:38:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id c7so13703410qka.7 for ; Mon, 14 Mar 2022 12:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z2xCG75NLwgybbs2yTPfuAA8Cy3FwErNT7ZUQEKClYg=; b=T9dGaLQhWlX6OKGb+SnMLEavBvkFONtt9IULiYq17WWkGisEOZEtmQt3/Oj7ytI05R oPBrzZybEu1+2NcOA3WVa50c9Z+EEpCtn5E0iV9aMOeqM4dPOF/7N7aZMVYZoLBtIUsN TajrpiGghGF6I7oGllcpKwPMGBAYjLdMElgK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z2xCG75NLwgybbs2yTPfuAA8Cy3FwErNT7ZUQEKClYg=; b=ED61n0n2PwZ21GDcShrIdNI+uyP9i++om0nnRLWZaN3jlG0Xh/Unf57CPO3V+N/iUV UwzUZO7b+baxYX8wRuEwB5nR2XnARWjnSa0/EoaGPDYZnxQzPWl4ap/juTnQdqqaK/AZ VAA+hAYmFGciru8dhgWpyAyoI0LdGqvNWQp9MHNxbuWEpbIkLlbNcezPgjvinwSPEsnd c0jaDJTijgFxbaN50kABX5yLwqc4Weid29nvqn3ZyvHVA98Oiz0a36PejBFHdKdJXsmr q1nayaIfTRFMcQ+HqY8sEShWBLM6Z9DgO4wsT+wfTIU6PDAGi24knTf7qlcUlEp8/Pan 18pA== X-Gm-Message-State: AOAM530lf7Wae/vR/DZDYcya8WYga+OtDepjPUaRFKFrmUNPPGgUBCJk viHI/4MLm8F+J/fGHvzKDuecPg== X-Google-Smtp-Source: ABdhPJxmqjqpRZYkRjA/uK3n4/N5POvYq2yVzvrYb1fIZTIGc1WPTzQ5dlUIOkEjX2gw80Fcr/uGGw== X-Received: by 2002:a37:c207:0:b0:67d:396a:bda7 with SMTP id i7-20020a37c207000000b0067d396abda7mr16037793qkm.731.1647286726610; Mon, 14 Mar 2022 12:38:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f7-20020a05622a104700b002d4b318692esm11836993qte.31.2022.03.14.12.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 12:38:45 -0700 (PDT) Date: Mon, 14 Mar 2022 15:38:43 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , AKASHI Takahiro , Heinrich Schuchardt , Patrick Delaunay , Wolfgang Denk Subject: Re: [PATCH 1/5] disk: Add an option for partitions in SPL Message-ID: <20220314193843.GO9986@bill-the-cat> References: <20220311191005.364540-1-sjg@chromium.org> <20220311191005.364540-2-sjg@chromium.org> <20220314124944.GD9986@bill-the-cat> <20220314183143.GM9986@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lA2zPjnDULdUXMNN" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --lA2zPjnDULdUXMNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2022 at 01:21:07PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 14 Mar 2022 at 12:31, Tom Rini wrote: > > > > On Mon, Mar 14, 2022 at 12:24:41PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 14 Mar 2022 at 06:49, Tom Rini wrote: > > > > > > > > On Fri, Mar 11, 2022 at 12:10:01PM -0700, Simon Glass wrote: > > > > > > > > > In some cases we do not want to enable partition support in SPL. = Add an > > > > > option to allow this. > > > > > > > > > > Signed-off-by: Simon Glass > > > > > --- > > > > > > > > > > disk/Kconfig | 24 ++++++++++++++++++++---- > > > > > disk/Makefile | 6 +++--- > > > > > drivers/block/blk-uclass.c | 2 +- > > > > > 3 files changed, 24 insertions(+), 8 deletions(-) > > > > > > > > I'm not sure this makes sense? I thought when I looked in to this = last > > > > the only place where we had partition code being linked and not > > > > discarded in the case of SPL and no devices that would have partiti= ons > > > > on them was one xilinx platform. How do we get to bringing in part= ition > > > > code and not having something that uses it? > > > > > > The problem is that drivers are not discarded and Takahiro's series > > > adds a driver for partitions. > > > > > > So yes, we were able to get away with this before, but cannot now. > > > > Things which aren't needed / used need to be discarded. So we might > > have use cases for this, yes (I was thinking after I sent that OK, yes, > > imx probably tends to not need partition support since we read at raw > > offsets, outside from maybe falcon mode using targets). But we > > shouldn't generally be now pulling in drivers that aren't functionally > > used. >=20 > We don't have a way of detecting whether a driver is used, with driver > model, so the only option is Kconfig. Does that make sense? Please let > me know if there is any disconnect here. Yes, it's possible that we have platforms enabling functionality they don't _need_, but unlikely (aside from the we don't need partition reading, we do raw offsets from block device only platforms). So there shouldn't be a whole bunch of stuff now being pulled in to SPL that wasn't before and doesn't need investigation / explanation. --=20 Tom --lA2zPjnDULdUXMNN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIvmcMACgkQFHw5/5Y0 tywMgAv+MTNWpGtLlA+LB8t9yE8f63FyebFZHGvERLJIu/1nh7ad+giVOfyej075 nsQCNJ34t8nEj/vNrQ8iRJTReP7FCML+MhfGKyr2Kgjad3qzMxS7dSmwN8e8p4c1 gqM2vnSl5tZaast8bts77zAqkpC5lJ5Po4ZfJCT2AHP+WZQpj919+NzKPVoeTFG7 VbqM085nmV4cSKTsR9uLyqYVjjBpHqDn6vlUJzh/QTAALn3pCxwkLlGNHF4h0Kx2 yhTK4KNzyGXvx3exbm5ev8Kit8fefeFIrMqTowIGkF2pSXm1+S4DINmyzDqKeMjm xCf5hAkSMKCEm4+WMJ9bGgyvHsvd5CSHn9KlofpXNwh92MGYkmgVguCrUCTCC3i1 QVSnZDg51rGMgh70ZnoVSLMqRV6t5QhTkvlPKpMSpO23MQZ0ociXbAD4AIS150hT ex7w7xIBsia/socfBcSPR+2Jt38sD/TTn2SNYkBKvk6ifJ7+ekE4ubBAuYVGpXjw QApAc9HM =5Ema -----END PGP SIGNATURE----- --lA2zPjnDULdUXMNN--