From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6BA7C433EF for ; Tue, 15 Mar 2022 15:37:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75DA983BF4; Tue, 15 Mar 2022 16:37:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ZiexUbP7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6151183BF4; Tue, 15 Mar 2022 16:37:41 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 99D3783C06 for ; Tue, 15 Mar 2022 16:37:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD2B861209; Tue, 15 Mar 2022 15:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E07FC340E8; Tue, 15 Mar 2022 15:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647358652; bh=ZbgXWZJzvDVPDX2eSSSiMCMw+Sv1lkkG+xupUGI+Kd4=; h=From:To:Cc:Subject:Date:From; b=ZiexUbP7jtPrnMNWA3tf8RuIDMUlolo2TEUpmP30A3Hkz2YmRtlUUo/mPLtMhJTUh Zl/EjXJQAObzVkcM9u/l6IzZuqpvRAwZiVvtJB7viD0nbgvejM+KKNdcs8UMqKrq9e 60UXBAKUjGsBKJvAudXKS7SwyZoxQTfIZYjptxDLDGo4sJXUytplX7NJCzPtddPR+5 2a9lk8cUVhjkpTk1t+dSjpIh/w2lpbtzLRhzvEKdjpoPSqsFNUEsZEo0GQ2ryqIb2f 8Mq8z439ieUckToMX0BwBBFi3iuuG4TDQ2UzxinPpM0L2UtVcXjYbwNdoLnamDDpP/ etVyZCjExLsdg== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Stefan Roese Cc: pali@kernel.org, "u-boot@lists.denx.de" , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working network / MDIO Date: Tue, 15 Mar 2022 16:37:27 +0100 Message-Id: <20220315153727.26089-1-kabel@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Marek Behún Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke network on Turris MOX, because the SOC's MDIO bus in U-Boot currently isn't probed via DM as it's own device, but is registered as part of mvneta's driver, which means that pinctrl definitions are not parsed for the MDIO bus node. Also mvneta driver does not consider "phy-handle" property, only "phy". For now, fix this by adding armada-3720-turris-mox-u-boot.dtsi file returning the MDIO to how it was defined previously. A better solution (using proper mvmdio DM driver) is being work on, but will need testing on various boards, and we need the bug fixed now for the upcoming release. Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún --- Dear Stefan, this fix is needed for the upcoming release, is it still possible? Thanks. Marek --- .../dts/armada-3720-turris-mox-u-boot.dtsi | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi new file mode 100644 index 0000000000..2e05b973d2 --- /dev/null +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * 2022 by Marek Behún + */ + +/ { + mdio { + #address-cells = <1>; + #size-cells = <0>; + + old_binding_phy1: ethernet-phy@1 { + reg = <1>; + }; + }; +}; + +ð0 { + pinctrl-0 = <&rgmii_pins>, <&smi_pins>; + /delete-property/ phy-handle; + phy = <&old_binding_phy1>; +}; + +/delete-node/ &mdio; -- 2.34.1