* [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs
@ 2022-03-19 15:45 Adam Ford
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Adam Ford @ 2022-03-19 15:45 UTC (permalink / raw)
To: u-boot; +Cc: sbabic, aford, Adam Ford
Because the Beacon imx8mm board uses device tree
for MMC/SD and Ethernet, there is no need to have some of the
config options. It's handled by the device tree.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/include/configs/imx8mm_beacon.h b/include/configs/imx8mm_beacon.h
index e4805951fa..7c17f14964 100644
--- a/include/configs/imx8mm_beacon.h
+++ b/include/configs/imx8mm_beacon.h
@@ -99,14 +99,4 @@
#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
sizeof(CONFIG_SYS_PROMPT) + 16)
-
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM 2
-#define CONFIG_SYS_FSL_ESDHC_ADDR 0
-
-/* FEC*/
-#define CONFIG_FEC_MXC_PHYADDR 0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE 0x30BE0000
-
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: imx: imx8mn_beacon: Remove unnecessary configs
2022-03-19 15:45 [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs Adam Ford
@ 2022-03-19 15:45 ` Adam Ford
2022-03-23 13:31 ` Fabio Estevam
2022-04-12 18:44 ` sbabic
2022-03-23 13:30 ` [PATCH 1/2] arm: imx: imx8mm_beacon: " Fabio Estevam
2022-04-12 18:43 ` sbabic
2 siblings, 2 replies; 6+ messages in thread
From: Adam Ford @ 2022-03-19 15:45 UTC (permalink / raw)
To: u-boot; +Cc: sbabic, aford, Adam Ford
Because the Beacon imx8mn board uses device tree
for MMC/SD and Ethernet, there is no need to have some of the
config options. It's handled by the device tree.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/include/configs/imx8mn_beacon.h b/include/configs/imx8mn_beacon.h
index 7fed9a38c1..41ce3c1c8c 100644
--- a/include/configs/imx8mn_beacon.h
+++ b/include/configs/imx8mn_beacon.h
@@ -115,16 +115,4 @@
#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
sizeof(CONFIG_SYS_PROMPT) + 16)
-
-/* USDHC */
-#define CONFIG_SYS_FSL_USDHC_NUM 2
-#define CONFIG_SYS_FSL_ESDHC_ADDR 0
-
-/* ENET Config */
-#if defined(CONFIG_FEC_MXC)
-#define CONFIG_FEC_MXC_PHYADDR 0
-#define FEC_QUIRK_ENET_MAC
-#define IMX_FEC_BASE 0x30BE0000
-#endif /* CONFIG_FEC_MXC */
-
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs
2022-03-19 15:45 [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs Adam Ford
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
@ 2022-03-23 13:30 ` Fabio Estevam
2022-04-12 18:43 ` sbabic
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-03-23 13:30 UTC (permalink / raw)
To: Adam Ford; +Cc: U-Boot-Denx, Stefano Babic, Adam Ford-BE
Hi Adam,
On Sat, Mar 19, 2022 at 12:45 PM Adam Ford <aford173@gmail.com> wrote:
>
> Because the Beacon imx8mm board uses device tree
> for MMC/SD and Ethernet, there is no need to have some of the
> config options. It's handled by the device tree.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Nice cleanup:
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm: imx: imx8mn_beacon: Remove unnecessary configs
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
@ 2022-03-23 13:31 ` Fabio Estevam
2022-04-12 18:44 ` sbabic
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-03-23 13:31 UTC (permalink / raw)
To: Adam Ford; +Cc: U-Boot-Denx, Stefano Babic, Adam Ford-BE
On Sat, Mar 19, 2022 at 12:45 PM Adam Ford <aford173@gmail.com> wrote:
>
> Because the Beacon imx8mn board uses device tree
> for MMC/SD and Ethernet, there is no need to have some of the
> config options. It's handled by the device tree.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs
2022-03-19 15:45 [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs Adam Ford
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
2022-03-23 13:30 ` [PATCH 1/2] arm: imx: imx8mm_beacon: " Fabio Estevam
@ 2022-04-12 18:43 ` sbabic
2 siblings, 0 replies; 6+ messages in thread
From: sbabic @ 2022-04-12 18:43 UTC (permalink / raw)
To: Adam Ford, u-boot
> Because the Beacon imx8mm board uses device tree
> for MMC/SD and Ethernet, there is no need to have some of the
> config options. It's handled by the device tree.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> diff --git a/include/configs/imx8mm_beacon.h b/include/configs/imx8mm_beacon.h
> index e4805951fa..7c17f14964 100644
> --- a/include/configs/imx8mm_beacon.h
> +++ b/include/configs/imx8mm_beacon.h
> @@ -99,14 +99,4 @@
> #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
> #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
> sizeof(CONFIG_SYS_PROMPT) + 16)
> -
> -/* USDHC */
> -#define CONFIG_SYS_FSL_USDHC_NUM 2
> -#define CONFIG_SYS_FSL_ESDHC_ADDR 0
> -
> -/* FEC*/
> -#define CONFIG_FEC_MXC_PHYADDR 0
> -#define FEC_QUIRK_ENET_MAC
> -#define IMX_FEC_BASE 0x30BE0000
> -
> #endif
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: imx: imx8mn_beacon: Remove unnecessary configs
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
2022-03-23 13:31 ` Fabio Estevam
@ 2022-04-12 18:44 ` sbabic
1 sibling, 0 replies; 6+ messages in thread
From: sbabic @ 2022-04-12 18:44 UTC (permalink / raw)
To: Adam Ford, u-boot
> Because the Beacon imx8mn board uses device tree
> for MMC/SD and Ethernet, there is no need to have some of the
> config options. It's handled by the device tree.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> diff --git a/include/configs/imx8mn_beacon.h b/include/configs/imx8mn_beacon.h
> index 7fed9a38c1..41ce3c1c8c 100644
> --- a/include/configs/imx8mn_beacon.h
> +++ b/include/configs/imx8mn_beacon.h
> @@ -115,16 +115,4 @@
> #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
> #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
> sizeof(CONFIG_SYS_PROMPT) + 16)
> -
> -/* USDHC */
> -#define CONFIG_SYS_FSL_USDHC_NUM 2
> -#define CONFIG_SYS_FSL_ESDHC_ADDR 0
> -
> -/* ENET Config */
> -#if defined(CONFIG_FEC_MXC)
> -#define CONFIG_FEC_MXC_PHYADDR 0
> -#define FEC_QUIRK_ENET_MAC
> -#define IMX_FEC_BASE 0x30BE0000
> -#endif /* CONFIG_FEC_MXC */
> -
> #endif
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-12 18:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-19 15:45 [PATCH 1/2] arm: imx: imx8mm_beacon: Remove unnecessary configs Adam Ford
2022-03-19 15:45 ` [PATCH 2/2] arm: imx: imx8mn_beacon: " Adam Ford
2022-03-23 13:31 ` Fabio Estevam
2022-04-12 18:44 ` sbabic
2022-03-23 13:30 ` [PATCH 1/2] arm: imx: imx8mm_beacon: " Fabio Estevam
2022-04-12 18:43 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox