From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71807C433EF for ; Mon, 21 Mar 2022 11:40:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6833A80F6F; Mon, 21 Mar 2022 12:40:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id ABB9883960; Mon, 21 Mar 2022 12:40:51 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id C3927800C2 for ; Mon, 21 Mar 2022 12:40:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1228C1042; Mon, 21 Mar 2022 04:40:47 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81A8A3F66F; Mon, 21 Mar 2022 04:40:45 -0700 (PDT) Date: Mon, 21 Mar 2022 11:39:58 +0000 From: Andre Przywara To: Petr =?UTF-8?B?xaB0ZXRpYXI=?= Cc: Jagan Teki , Tom Rini , Simon Glass , Jernej Skrabec , Samuel Holland , Chen-Yu Tsai , Icenowy Zheng , Jesse Taube , u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: A20-OLinuXino-LIME2 network regression [Was: [PATCH v2 1/5] sunxi: move non-essential code out of s_init()] Message-ID: <20220321113958.7e32066d@slackpad.lan> In-Reply-To: <20220320221031.GA20535@meh.true.cz> References: <20220201014116.25864-1-andre.przywara@arm.com> <20220201014116.25864-2-andre.przywara@arm.com> <20220320221031.GA20535@meh.true.cz> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, 20 Mar 2022 23:10:31 +0100 Petr =C5=A0tetiar wrote: Hi Petr, > Andre Przywara [2022-02-01 01:41:12]: >=20 > > Since we have an SPL, which is called right after s_init(), move those > > calls to our board_init_f() function. As we overwrite this only for > > the SPL, this has the added benefit of not doing this setup *again* > > shortly afterwards, when running U-Boot proper. =20 >=20 > something didn't went as expected, since this commit has broken ethernet = on my > A20-OLinuXino-LIME2: Thanks for the report, much appreciated! And yes, there is a regression, I figured this myself already the other week. I sent https://lore.kernel.org/u-boot/20220316005443.16260-1-andre.przywara@arm.co= m/ Can you check whether this fixes it for you? Then reply with a Tested-by:? I will then send the PR in the next days, so that 2022.04 should be fine. Thanks! Andre >=20 > U-Boot SPL 2022.04-rc4-00052-g2a243d9bd62f (Mar 20 2022 - 22:57:07 +0100) > DRAM: 1024 MiB > CPU: 912000000Hz, AXI/AHB/APB: 3/2/2 > Trying to boot from FEL >=20 >=20 > U-Boot 2022.04-rc4-00052-g2a243d9bd62f (Mar 20 2022 - 22:57:07 +0100) Al= lwinner Technology >=20 > CPU: Allwinner A20 (SUN7I) > Model: Olimex A20-OLinuXino-LIME2-eMMC > DRAM: 1 GiB > Core: 38 devices, 19 uclasses, devicetree: separate > WDT: Not starting watchdog@1c20c90 > MMC: mmc@1c0f000: 0, mmc@1c11000: 1 > Loading Environment from FAT... Unable to read "uboot.env" from mmc0:1... > Unknown monitor > Unknown monitor > In: serial > Out: serial > Err: serial > Allwinner mUSB OTG (Peripheral) > Net: Could not get PHY for ethernet@1c50000: addr 1 >=20 > Reverting this commit fixes it: >=20 > Net: eth0: ethernet@1c50000, eth1: usb_ether >=20 > Cheers, >=20 > Petr