From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
Date: Wed, 23 Mar 2022 14:00:12 +0100 [thread overview]
Message-ID: <20220323130012.vc424vvdalaesif3@pali> (raw)
In-Reply-To: <20220322161759.24301-1-kabel@kernel.org>
On Tuesday 22 March 2022 17:17:59 Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
>
> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
> voltage supply is described as a `phy-supply` property of connector
> node, a mechanism that is not supported in U-Boot yet.
>
> For now, fix this by adding `vbus-supply` to usb3 node.
>
> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Pali Rohár <pali@kernel.org>
Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another
Armada 3720 board) and both are working fine in U-Boot. Therefore no USB
fix is needed for Espressobin DTS file.
> ---
> Dear Stefan, as with the network issue, could we get this to master ASAP?
> ---
> arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> index 2e05b973d2..28a36a6103 100644
> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> @@ -21,3 +21,7 @@
> };
>
> /delete-node/ &mdio;
> +
> +&usb3 {
> + vbus-supply = <&exp_usb3_vbus>;
> +};
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-03-23 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
2022-03-23 5:55 ` Stefan Roese
2022-03-23 6:46 ` Stefan Roese
2022-03-23 11:46 ` Tom Rini
2022-03-23 13:00 ` Pali Rohár [this message]
2022-03-23 13:05 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323130012.vc424vvdalaesif3@pali \
--to=pali@kernel.org \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox