From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73500C433F5 for ; Fri, 25 Mar 2022 07:02:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 19BC184169; Fri, 25 Mar 2022 08:02:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="weKW1fBr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1143884168; Fri, 25 Mar 2022 08:02:11 +0100 (CET) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DCF1C84166 for ; Fri, 25 Mar 2022 08:02:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-io1-xd2a.google.com with SMTP id z6so7979303iot.0 for ; Fri, 25 Mar 2022 00:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=1zg986kZ00C2EBVHs6MwVvvYZZTzf4Y5VMgVjtFQC0A=; b=weKW1fBrFyyj4HXr63XhWMivwXfyNeIL0G4QW5tKy2ndFnXmvBT7D+CndUUKI9DhXX MWfyaf8J4qoFlJyclx/Xb5aY8mazy/Pk0NRwpcSELN6TJtlT8a0q67l2YviLNlnXgPYb HJQISXDWuYWqNFDQn1Uu+O/LiZAAwK8gGozwXHnu5v6qJ2EFAn0+5Xjju5vp7Tzru7l3 zpSH2Ahh/NpLAUbaiLdPyd5kUzyjoBSOSmh0+MJNhhDM2Vkw/dFoCuDpM20rmDIrZxp+ KGbmNJw0dGihW/TDIevcsXH89cOOfsmIaEvrnxk8fvCtATp5q7/nYRK0GZTrwwOmW8Zd ubBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=1zg986kZ00C2EBVHs6MwVvvYZZTzf4Y5VMgVjtFQC0A=; b=BhzKazcXdGBUYz42AdDd99LpFaVqn68eoViUQYrnVURPkkPiAb2SP8fkYBXMxdvDpq J8p9UUDcXoTv5vzdT9+ImYUL9ihz3QFaRYtRwCc8H7fD9JM5BAW2bPND5DgbmKwDLrAr iO29hbpI2+PW4YgCvA+NgGKgXG0txzO4QEqjJAKMQKLtf7apL9/p4Vq2R+c+rysbM3xv eAtkA4hbhbMqjH407e5vvQYyD5sTmYQ6/SZ/IAMFLgbIbiqlOrWrTSegTFiAKx/otxMr RKtF1dAdO/HLInRjrgYOxv9PeDhoJ3MkwLJ6sYe15OpbBRmJYznhTqfJYL7OYXTtwULh V2VA== X-Gm-Message-State: AOAM530DrENIl4LfpJfVdWPD+Qz/pFBQUOIZJXFJMCLnqpwBUgeGzSJZ IYZD4KRv5R/Wmfx3Bys2uDgQDkrKMVaMwhvw X-Google-Smtp-Source: ABdhPJzbBgUja81UughGaSg2LhhP2OWL6CtI3AlVaKbnmQroNoPGbjx/EvvchJP5VzPGl0LQWIesDg== X-Received: by 2002:a63:2004:0:b0:375:ed63:ab4c with SMTP id g4-20020a632004000000b00375ed63ab4cmr6836407pgg.255.1648191706491; Fri, 25 Mar 2022 00:01:46 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:15a6:15e9:1820:73]) by smtp.gmail.com with ESMTPSA id 132-20020a62168a000000b004f40e8b3133sm5941910pfw.188.2022.03.25.00.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 00:01:46 -0700 (PDT) Date: Fri, 25 Mar 2022 16:01:42 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Ilias Apalodimas Subject: Re: [PATCH v2 0/9] efi_loader: booting via short-form device-path Message-ID: <20220325070142.GC50025@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, Ilias Apalodimas References: <20220319091148.142036-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220319091148.142036-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Heinrich, I made the same complaint several times in the past. If I made some comments on your patches, don't merge them until we have reached the agreement even you are the maintainer. It's not the way how the community development should work. This happened again with this patch series. -Takahiro Akashi On Sat, Mar 19, 2022 at 10:11:39AM +0100, Heinrich Schuchardt wrote: > The GUID of partitions is sufficient for identification and will stay > constant in the lifetime of a boot option. The preceding path of the > device-path may change due to changes in the enumeration of devices. > Therefore it is preferable to use the short-form of device-paths in load > options. > > > With this series booting via short-form device-paths is reenable. > The 'efidebug boot add' command is adjusted to create either short-form > or long-form device paths. > > The check for the EFI System Partition used for capsule updates is > corrected. > > A unit test for the boot manager is added. > > v2: > merge multiple patches to a series > fix ESP detection > > Heinrich Schuchardt (9): > efi_loader: export efi_dp_shorten() > efi_loader: fix efi_dp_find_obj() > efi_loader: efi_dp_find_obj() add protocol check > efi_loader: support booting via short-form device-path > efi_loader: use short-form DP for load options > efi_loader: export efi_system_partition_guid > efi_loader: remove efi_disk_is_system_part() > efi_loader: move dtbdump.c, initrddump.c to lib/efi_loader > test: test UEFI boot manager > > cmd/efidebug.c | 70 ++- > include/efi_loader.h | 12 +- > lib/efi_loader/Makefile | 12 + > lib/efi_loader/dtbdump.c | 539 ++++++++++++++++++ > lib/efi_loader/efi_boottime.c | 22 +- > lib/efi_loader/efi_capsule.c | 13 +- > lib/efi_loader/efi_device_path.c | 138 +++-- > lib/efi_loader/efi_disk.c | 31 +- > lib/efi_loader/initrddump.c | 449 +++++++++++++++ > lib/efi_selftest/Makefile | 12 - > lib/efi_selftest/dtbdump.c | 539 ------------------ > lib/efi_selftest/initrddump.c | 449 --------------- > test/py/tests/test_efi_bootmgr/conftest.py | 42 ++ > .../test_efi_bootmgr/test_efi_bootmgr.py | 31 + > 14 files changed, 1232 insertions(+), 1127 deletions(-) > create mode 100644 lib/efi_loader/dtbdump.c > create mode 100644 lib/efi_loader/initrddump.c > delete mode 100644 lib/efi_selftest/dtbdump.c > delete mode 100644 lib/efi_selftest/initrddump.c > create mode 100644 test/py/tests/test_efi_bootmgr/conftest.py > create mode 100644 test/py/tests/test_efi_bootmgr/test_efi_bootmgr.py > > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F01AC433F5 for ; Fri, 25 Mar 2022 09:12:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F7E284156; Fri, 25 Mar 2022 10:12:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CufXXe15"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF0818414A; Fri, 25 Mar 2022 10:12:51 +0100 (CET) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7FC0840F9 for ; Fri, 25 Mar 2022 10:12:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x635.google.com with SMTP id w4so7373008ply.13 for ; Fri, 25 Mar 2022 02:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=1zg986kZ00C2EBVHs6MwVvvYZZTzf4Y5VMgVjtFQC0A=; b=CufXXe15X85DLjqh4TWzwxPLWFJ+uV9FiMT5fqE0+7k9NzhZ42OAKWNj5wH7sCUHfS sfNvKsMZT8Rb7jWORaIgJkHLgQ2teSXQOXvXmZwWhUb3hCxUgg65S5/izxnmcxt9siFG n6zCvuFQb0vPMlgNE0W5vH4Dyw/Bt97MMUqiuylTjv2hVlGwJTrY8rFZttzxXTh1+E14 AEglxoNzWnYyeACOQxIMsUMlag6YjVIMNnwIRhmxiKe9YCJ0bhNRmRDiwNUShTnmtve4 f3kTnNm+og5aywqPT5+lhIZorfMqe1Wuv24YdINJ5hNThfdzSevC6V/SiLo2kmcELeiB v20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=1zg986kZ00C2EBVHs6MwVvvYZZTzf4Y5VMgVjtFQC0A=; b=sVNgVHivbWdgZWit0B4MiCBmpoXIM5Xejvt9YQRSJ4sfX5naRUUMuE8OjdWr3NBil9 DjIZ1IGmAG9HgXoO9bsa5CUqQwYtJfHzb2Bpcdh/D9PKlI9uQSZBBriUud6lwXuqUnQf o9Y9syAJ64nAqvv19NdZZ2Hg220b1CwQFx87g1/ukAyvS6h01in7xciMjMjKbgY8TQrm fEfogusbVvifmto8ixaGg+Zhce6QtxY+h9pwHfnnRHNrVTqGdezZ9lr7vojlC8ePYAJq F4pMnaT7ua1VszYRKqBhMt/8YF0MlfmH9cDpkjBraEKpe1WvDHvb+J5+MiCTluNp+xH3 vVZw== X-Gm-Message-State: AOAM533zqMK2unGbbG652mdbye+GT3lFS46bMOJZ/mWEUZMbA+mkK74P qrJPA+fs9mg2kiQvD5LAnotONg== X-Google-Smtp-Source: ABdhPJxaYTVYClvMcnm+ghKiaYayEUX9gE3R4zolpnliP6PbG+028hbVmN+m67XC6tp5xCjIgfQs5A== X-Received: by 2002:a17:902:bc86:b0:151:ec83:4a8b with SMTP id bb6-20020a170902bc8600b00151ec834a8bmr10360937plb.69.1648199566860; Fri, 25 Mar 2022 02:12:46 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:15a6:15e9:1820:73]) by smtp.gmail.com with ESMTPSA id u19-20020a056a00125300b004fafa43330csm4122470pfi.163.2022.03.25.02.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 02:12:46 -0700 (PDT) Date: Fri, 25 Mar 2022 18:12:43 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Ilias Apalodimas Subject: Re: [PATCH v2 0/9] efi_loader: booting via short-form device-path Message-ID: <20220325070142.GC50025@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, Ilias Apalodimas References: <20220319091148.142036-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220319091148.142036-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Message-ID: <20220325091243.CZuX27mb6MzG3ku4qsW1gehb_gDi7I7364uuwtt2CAg@z> Heinrich, I made the same complaint several times in the past. If I made some comments on your patches, don't merge them until we have reached the agreement even you are the maintainer. It's not the way how the community development should work. This happened again with this patch series. -Takahiro Akashi On Sat, Mar 19, 2022 at 10:11:39AM +0100, Heinrich Schuchardt wrote: > The GUID of partitions is sufficient for identification and will stay > constant in the lifetime of a boot option. The preceding path of the > device-path may change due to changes in the enumeration of devices. > Therefore it is preferable to use the short-form of device-paths in load > options. > > > With this series booting via short-form device-paths is reenable. > The 'efidebug boot add' command is adjusted to create either short-form > or long-form device paths. > > The check for the EFI System Partition used for capsule updates is > corrected. > > A unit test for the boot manager is added. > > v2: > merge multiple patches to a series > fix ESP detection > > Heinrich Schuchardt (9): > efi_loader: export efi_dp_shorten() > efi_loader: fix efi_dp_find_obj() > efi_loader: efi_dp_find_obj() add protocol check > efi_loader: support booting via short-form device-path > efi_loader: use short-form DP for load options > efi_loader: export efi_system_partition_guid > efi_loader: remove efi_disk_is_system_part() > efi_loader: move dtbdump.c, initrddump.c to lib/efi_loader > test: test UEFI boot manager > > cmd/efidebug.c | 70 ++- > include/efi_loader.h | 12 +- > lib/efi_loader/Makefile | 12 + > lib/efi_loader/dtbdump.c | 539 ++++++++++++++++++ > lib/efi_loader/efi_boottime.c | 22 +- > lib/efi_loader/efi_capsule.c | 13 +- > lib/efi_loader/efi_device_path.c | 138 +++-- > lib/efi_loader/efi_disk.c | 31 +- > lib/efi_loader/initrddump.c | 449 +++++++++++++++ > lib/efi_selftest/Makefile | 12 - > lib/efi_selftest/dtbdump.c | 539 ------------------ > lib/efi_selftest/initrddump.c | 449 --------------- > test/py/tests/test_efi_bootmgr/conftest.py | 42 ++ > .../test_efi_bootmgr/test_efi_bootmgr.py | 31 + > 14 files changed, 1232 insertions(+), 1127 deletions(-) > create mode 100644 lib/efi_loader/dtbdump.c > create mode 100644 lib/efi_loader/initrddump.c > delete mode 100644 lib/efi_selftest/dtbdump.c > delete mode 100644 lib/efi_selftest/initrddump.c > create mode 100644 test/py/tests/test_efi_bootmgr/conftest.py > create mode 100644 test/py/tests/test_efi_bootmgr/test_efi_bootmgr.py > > -- > 2.34.1 >