* [PATCH v3] imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default
@ 2022-03-26 14:47 Fabio Estevam
2022-04-07 14:22 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2022-03-26 14:47 UTC (permalink / raw)
To: sbabic
Cc: u-boot, heiko.thiery, xypron.glpk, trini, aford173,
marcel.ziswiler, mingkai.hu, priyanka.jain, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
When adding new features to imx8m boards, such as DM clock support,
the malloc area can be exhausted.
To avoid such issue, provide a reasonable default for the
SYS_MALLOC_F_LEN size.
Quoting Tom Rini:
"This seems to be an area where everyone is either:
- Kicking the value up a bit for themselves
- Having hard to figure out problems booting the platform because it's
too small a value until they see someone else picked a larger value.
So lets raise these a bit and get some acks, please."
Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Fabio Estevam <festevam@denx.de>
Tested-by: Adam Ford <aford173@gmail.com> #imx8mm-beacon, imx8mn-beacon
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
---
Changes since v2:
- Also bump the default for imx8/layerscape - Tom
- Expand the Cc list - Tom
Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Kconfig b/Kconfig
index 9dd9ec7f6dfb..8b346894e581 100644
--- a/Kconfig
+++ b/Kconfig
@@ -232,10 +232,10 @@ config SYS_MALLOC_F_LEN
depends on SYS_MALLOC_F
default 0x1000 if AM33XX
default 0x4000 if SANDBOX
- default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
- ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5 || \
- ARCH_LS1012A || ARCH_LS1021A || ARCH_LS1043A || \
- ARCH_LS1046A || ARCH_QEMU || ARCH_SUNXI || ARCH_OWL)
+ default 0x2000 if (ARCH_MX7 || ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5 || \
+ ARCH_QEMU || ARCH_SUNXI || ARCH_OWL)
+ default 0x10000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_LS1012A || \
+ ARCH_LS1021A || ARCH_LS1043A || ARCH_LS1046A)
default 0x400
help
Before relocation, memory is very limited on many platforms. Still,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default
2022-03-26 14:47 [PATCH v3] imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default Fabio Estevam
@ 2022-04-07 14:22 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-04-07 14:22 UTC (permalink / raw)
To: Fabio Estevam
Cc: sbabic, u-boot, heiko.thiery, xypron.glpk, aford173,
marcel.ziswiler, mingkai.hu, priyanka.jain, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Sat, Mar 26, 2022 at 11:47:40AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> When adding new features to imx8m boards, such as DM clock support,
> the malloc area can be exhausted.
>
> To avoid such issue, provide a reasonable default for the
> SYS_MALLOC_F_LEN size.
>
> Quoting Tom Rini:
>
> "This seems to be an area where everyone is either:
> - Kicking the value up a bit for themselves
> - Having hard to figure out problems booting the platform because it's
> too small a value until they see someone else picked a larger value.
>
> So lets raise these a bit and get some acks, please."
>
> Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Tested-by: Adam Ford <aford173@gmail.com> #imx8mm-beacon, imx8mn-beacon
> Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-07 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-26 14:47 [PATCH v3] imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default Fabio Estevam
2022-04-07 14:22 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox