From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4A48C433F5 for ; Tue, 29 Mar 2022 23:22:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E7F283FD7; Wed, 30 Mar 2022 01:22:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="wrxgWlFC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6245484032; Wed, 30 Mar 2022 01:22:27 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3540A83FD7 for ; Wed, 30 Mar 2022 01:22:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id A9C441406DA; Wed, 30 Mar 2022 01:22:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1648596143; bh=ujR4U0PDvcvHq4NSpS+wEZAA4a/GHOx27MpNTVtlVV0=; h=Date:From:To; b=wrxgWlFCJmX2hsQhaYHwWSbEsLr+JizJIQD+keoFfcXONQwcRsD/3HNrxgnW9446l imcEijdErTtrq7uxIoROWLIknGiuaxjaIV3fyL429CEbYI6lb52ak94j+D51YzAQ9S tiSCltWPwQqsrYePFZ9ztE2/kfZkMUbFX4pluJ2A= Date: Wed, 30 Mar 2022 01:22:23 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Tim Harvey Cc: Joe Hershberger , Ramon Fried , Vladimir Oltean , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH 5/6] net: add MV88E61xx DSA driver Message-ID: <20220330012223.71ea3812@thinkpad> In-Reply-To: <20220329225240.1416-6-tharvey@gateworks.com> References: <20220329225240.1416-1-tharvey@gateworks.com> <20220329225240.1416-6-tharvey@gateworks.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, 29 Mar 2022 15:52:39 -0700 Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Signed-off-by: Tim Harvey Is this final version that should be accepted? The drivers seems to support not only 61xx, but 6xxx (6096, 6250, 6352, ...). Also there are some commented lines, for example > +// u16 port_stat_link_mask;/* Bitmask for port link status bits */ > +// u16 port_stat_dup_mask; /* Bitmask for port duplex status bits */ > +// u8 port_stat_speed_width;/* Width of speed status bitfield */ What is their purpose? Why is mv88e61xx_dsa_xmit() no-op? Marek