* [PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS
@ 2022-03-30 9:14 Andy Shevchenko
2022-03-30 19:18 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-03-30 9:14 UTC (permalink / raw)
To: Simon Glass, u-boot; +Cc: Heinrich Schuchardt, Tom Rini, Andy Shevchenko
It seems a copy'n'paste typo when tool had been introduced.
It has never had the 'exit' suffix in the file name. Hence,
the custom CFLAGS never been applied and, for example, BFD
linker complains:
LD lib/efi_loader/initrddump_efi.so
ld.bfd: lib/efi_loader/initrddump.o: warning: relocation in read-only section `.text.efi_main'
ld.bfd: warning: creating DT_TEXTREL in a shared object
Remove wrong 'exit' suffix from the custom CFLAGS variable.
Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/efi_loader/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
index befed7144e78..034d26cf0109 100644
--- a/lib/efi_loader/Makefile
+++ b/lib/efi_loader/Makefile
@@ -16,7 +16,7 @@ CFLAGS_helloworld.o := $(CFLAGS_EFI) -Os -ffreestanding
CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI)
CFLAGS_dtbdump.o := $(CFLAGS_EFI) -Os -ffreestanding
CFLAGS_REMOVE_dtbdump.o := $(CFLAGS_NON_EFI)
-CFLAGS_initrddump_exit.o := $(CFLAGS_EFI) -Os -ffreestanding
+CFLAGS_initrddump.o := $(CFLAGS_EFI) -Os -ffreestanding
CFLAGS_REMOVE_initrddump.o := $(CFLAGS_NON_EFI)
ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),)
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS
2022-03-30 9:14 [PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS Andy Shevchenko
@ 2022-03-30 19:18 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-03-30 19:18 UTC (permalink / raw)
To: Andy Shevchenko, Simon Glass, u-boot; +Cc: Tom Rini
On 3/30/22 11:14, Andy Shevchenko wrote:
> It seems a copy'n'paste typo when tool had been introduced.
> It has never had the 'exit' suffix in the file name. Hence,
> the custom CFLAGS never been applied and, for example, BFD
> linker complains:
>
> LD lib/efi_loader/initrddump_efi.so
> ld.bfd: lib/efi_loader/initrddump.o: warning: relocation in read-only section `.text.efi_main'
> ld.bfd: warning: creating DT_TEXTREL in a shared object
>
> Remove wrong 'exit' suffix from the custom CFLAGS variable.
>
> Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> lib/efi_loader/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index befed7144e78..034d26cf0109 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -16,7 +16,7 @@ CFLAGS_helloworld.o := $(CFLAGS_EFI) -Os -ffreestanding
> CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI)
> CFLAGS_dtbdump.o := $(CFLAGS_EFI) -Os -ffreestanding
> CFLAGS_REMOVE_dtbdump.o := $(CFLAGS_NON_EFI)
> -CFLAGS_initrddump_exit.o := $(CFLAGS_EFI) -Os -ffreestanding
> +CFLAGS_initrddump.o := $(CFLAGS_EFI) -Os -ffreestanding
> CFLAGS_REMOVE_initrddump.o := $(CFLAGS_NON_EFI)
>
> ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-30 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 9:14 [PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS Andy Shevchenko
2022-03-30 19:18 ` Heinrich Schuchardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox