From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58A17C433EF for ; Wed, 30 Mar 2022 12:16:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C7A3684053; Wed, 30 Mar 2022 14:16:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="M2B/hu36"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5D8A0840B3; Wed, 30 Mar 2022 14:16:07 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E6DE84021 for ; Wed, 30 Mar 2022 14:16:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id 09F7013FAA4; Wed, 30 Mar 2022 14:16:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1648642562; bh=UvvTM27FaJn3Cr4F9kalJDBC2zSI1eZM62SQYkM610o=; h=Date:From:To; b=M2B/hu36p50evhCPIteln4Tp9TgYzlDxprcIDZSAEPhTKP+3QJI3fFiexw4/ISG5r EgzFOJ2Y/zeSiGaqNaqL00CDEl3bse2UZi4h++zO+RDJhggiD2x8XP7McjkMNvKL6g LFmfpjFWNC8kmj0R+p7zWEBwLqIkBZoDDFXwasn4= Date: Wed, 30 Mar 2022 14:16:01 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: u-boot@lists.denx.de, Ramon Fried , Joe Hershberger , Aaron Williams , Chandrakala Chavva Subject: Re: [PATCH 1/2] net: phy: marvell: Support reg config via "marvell, reg-init" DT property Message-ID: <20220330141601.3225c713@thinkpad> In-Reply-To: <20220330083826.829473-1-sr@denx.de> References: <20220330083826.829473-1-sr@denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 30 Mar 2022 10:38:25 +0200 Stefan Roese wrote: > This patch adds support for the "marvell,reg-init" DT property, which > is used to describe board specific Marvell PHY register configurations > in the board dts file. This DT property is supported in the Linux Kernel > since a longer time. Adding it to U-Boot now, enables the boards which > describe the register settings in their DT files here as well. > > I've included calling this marvell_of_reg_init() to all foo_config() > functions in this patch as well. If CONFIG_DM_ETH is not set, there is > no ofnode, or no "marvell,reg-init" property, the PHY initialization is > unchanged. > > The function marvell_of_reg_init() is a port of the Linux version. > Please note that I explicitly did not add error checking and handling > to the U-Boot version, as this is basically not done for phy_read/write > in this Marvell PHY code. > > This will be used by the upcoming ethernet support on the MIPS > Octeon EBB 7304 board. > > Signed-off-by: Stefan Roese > Cc: Ramon Fried > Cc: Joe Hershberger > Cc: Aaron Williams > Cc: Chandrakala Chavva Hi Stefan, I know this property is used also in kernel, but what do you want to use it for? Because in kernel the idea is to deprecate it. It is used for example to confiure INT pin, but that should have it's own property once someone implements it. It is also used to configure LEDs, and that is hopefully gonna be obsoleted by supporting the LEDs via the LED subsystem, so afterwards we will write ethernet-phy@1 { leds { led@0 { color = ...; }; }; }; Marek