From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 272AEC433EF for ; Wed, 30 Mar 2022 16:55:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7CB038413C; Wed, 30 Mar 2022 18:55:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IrGWHwGC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7CEBC8413F; Wed, 30 Mar 2022 18:55:05 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2F5F484120 for ; Wed, 30 Mar 2022 18:54:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x731.google.com with SMTP id v13so17134062qkv.3 for ; Wed, 30 Mar 2022 09:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n3mZaka43dvhiXJwScfvjaldZdBNICmaynKTQPWERH8=; b=IrGWHwGCB8OHaqac6r43BOQmuSgEDRu5srxm3suR06ipGYGcv6ETgzBk3WpI1lcJGg MrXekZ+nvhEF/7in60k2wk6GyMP9zOv1iX1bogc/O3jhUVZzRlhLJatwW64EugwHEx3y clgQaU3Z3mAm1/l5rtt10fRC/xWlFXYnn/g77j8uG8an8JZsPdDdhuxpJR8FXV5/JAcB 0a66WiTMAmr+mcJV7oSPD+3RWN01amvNmTjnBVjXHyNJFc2yeTPPjLGY3nmr4sbhqUVE ICM+zceFn3CcNViKZw6DPsBjrNxxIEw/kgGuzDo63HE4E5plUQ+ouAtfoZVHu32AzPb/ uYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n3mZaka43dvhiXJwScfvjaldZdBNICmaynKTQPWERH8=; b=KrlOIu/LnHQKmPxAbbsUhNOGm63PgSsU+zNDSwObvEUgyNN5xLLueQUDdjIFK4LgY7 iDO8eo8futXFlwWHVrWaAXSsCEWWQuD9SqaRVIR7SWLIAOO07Pam8ISIKwLOP2dTXrzx 6+WR6nNQ3a+sFBEAyPLP5ILN2FolQcW1ccNtMsA/egwK07nSXWj3FaMh1IFx9+fAI/Iy S/3f+7OX4MMVpxXbRrEc2qzHSYdNbnknFc8nfSH72YoK9VgKsa1qb/QBiTc+oCEqIkot HTM9i4uDPth1xIBMt3ZEd69xyrvM7Ep+8EKiWxc24TqFE5MWm2xc5xz9hYAtTqzr6+aD hyPw== X-Gm-Message-State: AOAM533MD7GYUmoJyyl/sLS9leMRrlvl59I+2pTPKNWYBS/YWafPVLR7 srAmhmTnARsj2+6F3+pywywxwdvFgdw= X-Google-Smtp-Source: ABdhPJyLfmWQYWFHZSvP5q8gnkH0e9MYTD+8C6nFnEWGDXm3T5ayuYPuaDige0st9kPRNWMU+cAfIA== X-Received: by 2002:a37:6408:0:b0:67b:119c:9ee6 with SMTP id y8-20020a376408000000b0067b119c9ee6mr414923qkb.155.1648659294796; Wed, 30 Mar 2022 09:54:54 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id p16-20020a05622a13d000b002e227782e9asm17298150qtk.14.2022.03.30.09.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 09:54:54 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de Cc: Peng Fan , Simon Glass , Jaehoon Chung , Sean Anderson Subject: [PATCH 4/4] mmc: sandbox: Set the response Date: Wed, 30 Mar 2022 12:54:46 -0400 Message-Id: <20220330165446.438925-5-seanga2@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330165446.438925-1-seanga2@gmail.com> References: <20220330165446.438925-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The mmc subsystem checks the response, but we (almost) never set it. Add a bare-bones implementation. Technically, we are supposed to return our current state in our responses, but I don't think the subsystem checks it. Signed-off-by: Sean Anderson --- drivers/mmc/sandbox_mmc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/sandbox_mmc.c b/drivers/mmc/sandbox_mmc.c index 60a6be0add..8922eeba2a 100644 --- a/drivers/mmc/sandbox_mmc.c +++ b/drivers/mmc/sandbox_mmc.c @@ -44,6 +44,9 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, struct mmc *mmc = mmc_get_mmc_dev(dev); static ulong erase_start, erase_end; + /* Default R1 response */ + cmd->response[0] = R1_READY_FOR_DATA; + switch (cmd->cmdidx) { case MMC_CMD_ALL_SEND_CID: memset(cmd->response, '\0', sizeof(cmd->response)); @@ -55,8 +58,8 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, case SD_CMD_SEND_IF_COND: cmd->response[0] = 0xaa; break; - case MMC_CMD_SEND_STATUS: - cmd->response[0] = MMC_STATUS_RDY_FOR_DATA; + case SD_CMD_APP_SD_STATUS: + cmd->response[0] |= R1_APP_CMD; memset(data->dest, '\0', data->blocks * data->blocksize); break; case MMC_CMD_SELECT_CARD: @@ -106,6 +109,7 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, cmd->response[2] = 0; break; case MMC_CMD_APP_CMD: + cmd->response[0] |= R1_APP_CMD; break; case MMC_CMD_SET_BLOCKLEN: debug("block len %d\n", cmd->cmdarg); @@ -113,11 +117,13 @@ static int sandbox_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, case SD_CMD_APP_SEND_SCR: { u32 *scr = (u32 *)data->dest; + cmd->response[0] |= R1_APP_CMD; scr[0] = cpu_to_be32(2 << 24 | 1 << 15); /* SD version 3 */ break; } default: debug("%s: Unknown command %d\n", __func__, cmd->cmdidx); + cmd->response[0] |= R1_ILLEGAL_COMMAND; break; } -- 2.35.1