From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Cc: Kamil Lulko <kamil.lulko@gmail.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
uboot-stm32@st-md-mailman.stormreply.com
Subject: [PATCH 09/25] stm32f429-discovery: Migrate CONFIG_*_LED out of CONFIG namespace
Date: Wed, 30 Mar 2022 18:07:19 -0400 [thread overview]
Message-ID: <20220330220735.908616-9-trini@konsulko.com> (raw)
In-Reply-To: <20220330220735.908616-1-trini@konsulko.com>
These values are only used in one file, reference them more directly.
Cc: Kamil Lulko <kamil.lulko@gmail.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: uboot-stm32@st-md-mailman.stormreply.com
Signed-off-by: Tom Rini <trini@konsulko.com>
---
board/st/stm32f429-discovery/led.c | 19 +++++++++++--------
include/configs/stm32f429-discovery.h | 3 ---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c
index 539c139bb5dd..8dda6a97bd1c 100644
--- a/board/st/stm32f429-discovery/led.c
+++ b/board/st/stm32f429-discovery/led.c
@@ -8,30 +8,33 @@
#include <status_led.h>
#include <asm-generic/gpio.h>
+#define RED_LED 110
+#define GREEN_LED 109
+
void coloured_LED_init(void)
{
- gpio_request(CONFIG_RED_LED, "red led");
- gpio_direction_output(CONFIG_RED_LED, 0);
- gpio_request(CONFIG_GREEN_LED, "green led");
- gpio_direction_output(CONFIG_GREEN_LED, 0);
+ gpio_request(RED_LED, "red led");
+ gpio_direction_output(RED_LED, 0);
+ gpio_request(GREEN_LED, "green led");
+ gpio_direction_output(GREEN_LED, 0);
}
void red_led_off(void)
{
- gpio_set_value(CONFIG_RED_LED, 0);
+ gpio_set_value(RED_LED, 0);
}
void green_led_off(void)
{
- gpio_set_value(CONFIG_GREEN_LED, 0);
+ gpio_set_value(GREEN_LED, 0);
}
void red_led_on(void)
{
- gpio_set_value(CONFIG_RED_LED, 1);
+ gpio_set_value(RED_LED, 1);
}
void green_led_on(void)
{
- gpio_set_value(CONFIG_GREEN_LED, 1);
+ gpio_set_value(GREEN_LED, 1);
}
diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
index c9649a085ef1..21bab5aafd54 100644
--- a/include/configs/stm32f429-discovery.h
+++ b/include/configs/stm32f429-discovery.h
@@ -17,9 +17,6 @@
#define CONFIG_SYS_MAX_FLASH_SECT 12
-#define CONFIG_RED_LED 110
-#define CONFIG_GREEN_LED 109
-
#define CONFIG_SYS_HZ_CLOCK 1000000 /* Timer is clocked at 1MHz */
#define CONFIG_SYS_CBSIZE 1024
--
2.25.1
next prev parent reply other threads:[~2022-03-30 22:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 22:07 [PATCH 01/25] Convert CONFIG_BOARD_SIZE_LIMIT to Kconfig Tom Rini
2022-03-30 22:07 ` [PATCH 02/25] mvebu: Move BOOTROM_ERR_REG out of CONFIG namespace Tom Rini
2022-03-31 8:58 ` Stefan Roese
2022-04-08 18:02 ` Tom Rini
2022-03-30 22:07 ` [PATCH 03/25] tegra: Migrate CI_UDC_HAS_HOSTPC to Kconfig Tom Rini
2022-04-01 16:21 ` Peter Robinson
2022-04-08 18:02 ` Tom Rini
2022-03-30 22:07 ` [PATCH 04/25] Convert CONFIG_CMDLINE_PS_SUPPORT " Tom Rini
2022-04-08 18:02 ` Tom Rini
2022-03-30 22:07 ` [PATCH 05/25] arm: integrator: Migrate platform-specific options and cleanup armcoremodule.h Tom Rini
2022-04-08 18:02 ` Tom Rini
2022-03-30 22:07 ` [PATCH 06/25] s5p_goni, smdkc100: Move some environment settings out of CONFIG Tom Rini
2022-04-04 4:19 ` Minkyu Kang
2022-04-08 18:02 ` Tom Rini
2022-04-22 12:04 ` Jaehoon Chung
2022-03-30 22:07 ` [PATCH 07/25] MPC837XERDB: Stop using CONFIG_RAMDISKFILE Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 08/25] corvus: Migrate CONFIG_*_LED out of CONFIG namespace Tom Rini
2022-03-31 4:19 ` Heiko Schocher
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` Tom Rini [this message]
2022-03-31 7:20 ` [PATCH 09/25] stm32f429-discovery: " Patrice CHOTARD
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 10/25] at91: Remove unused LED code Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 11/25] Convert CONFIG_CONS_SCIF0 et al to Kconfig Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 12/25] Convert CONFIG_SH_SCIF_CLK_FREQ " Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK " Tom Rini
2022-03-31 16:30 ` Pratyush Yadav
2022-03-31 17:41 ` Tom Rini
2022-03-31 18:54 ` Pratyush Yadav
2022-03-31 19:35 ` [v2 " Tom Rini
2022-03-31 19:43 ` Pratyush Yadav
2022-04-08 14:47 ` Tom Rini
2022-04-11 19:05 ` Pratyush Yadav
2022-04-11 19:30 ` Tom Rini
2022-04-08 18:05 ` [PATCH " Tom Rini
2022-03-30 22:07 ` [PATCH 14/25] controlcenterdc: Migrate CUSTOMER_BOARD_SUPPORT " Tom Rini
2022-03-31 9:00 ` Stefan Roese
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 15/25] tegra: Drop CONFIG_CHROMEOS_EXTRA_ENV_SETTINGS Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 16/25] microblaze: Migrate DCACHE/ICACHE to Kconfig Tom Rini
2022-03-31 5:42 ` Michal Simek
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 17/25] ls1021atwr: Use DEBUG and not CONFIG_DEBUG Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 18/25] nds32: Migrate CONFIG_DEBUG_LED to Kconfig Tom Rini
2022-04-08 18:03 ` Tom Rini
2022-03-30 22:07 ` [PATCH 19/25] powerpc: mpc83xx: Migrate DEFAULT_IMMR " Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 20/25] galileo: Remove CONFIG_DESIGNWARE_ETH reference Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 21/25] Convert CONFIG_DIMM_SLOTS_PER_CTLR to Kconfig Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 22/25] Convert CONFIG_FSL_QIXIS et al " Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 23/25] m53menlo: Drop CONFIG_DISCOVER_PHY Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 24/25] siemens-am33x-common: Drop CONFIG_DMA_COHERENT* Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-03-30 22:07 ` [PATCH 25/25] arm: fsl-layerscape: Migrate more DP-DDR options to Kconfig Tom Rini
2022-04-08 18:04 ` Tom Rini
2022-04-08 18:02 ` [PATCH 01/25] Convert CONFIG_BOARD_SIZE_LIMIT " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330220735.908616-9-trini@konsulko.com \
--to=trini@konsulko.com \
--cc=kamil.lulko@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox