From: Tom Rini <trini@konsulko.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Simon Glass <sjg@chromium.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
u-boot@lists.denx.de, Bin Meng <bmeng.cn@gmail.com>,
u-boot-custodians@lists.denx.de,
u-boot-board-maintainers@lists.denx.de,
Ferry Toth <fntoth@gmail.com>
Subject: Re: [PATCH v1 1/1] Revert "x86: Move FACP table into separate functions"
Date: Thu, 31 Mar 2022 09:38:58 -0400 [thread overview]
Message-ID: <20220331133858.GA14476@bill-the-cat> (raw)
In-Reply-To: <20220330154918.21107-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
On Wed, Mar 30, 2022 at 06:49:18PM +0300, Andy Shevchenko wrote:
> Before the culprit patch (see BugLink for the details):
>
> => acpi list
> Name Base Size Detail
> ---- -------- ----- ------
> RSDP 000e4500 24 v02 U-BOOT
> RSDT 000e4530 38 v01 U-BOOT U-BOOTBL 20220401 INTL 0
> XSDT 000e45e0 4c v01 U-BOOT U-BOOTBL 20220401 INTL 0
> CSRT 000e5490 58 v00 U-BOOT U-BOOTBL 20220401 INTL 0
> FACP 000e54f0 114 v06 U-BOOT U-BOOTBL 20220401 INTL 0
> DSDT 000e4780 c06 v02 U-BOOT U-BOOTBL 10000 INTL 20200925
> FACS 000e4740 40
> MCFG 000e5610 3c v01 U-BOOT U-BOOTBL 20220401 INTL 0
> SPCR 000e5650 50 v02 U-BOOT U-BOOTBL 20220401 INTL 0
> APIC 000e56a0 48 v02 U-BOOT U-BOOTBL 20220401 INTL 0
>
> After the culprit patch:
>
> => acpi list
> Name Base Size Detail
> ---- -------- ----- ------
> RSDP 000e4500 24 v02 U-BOOT
> RSDT 000e4530 34 v01 U-BOOT U-BOOTBL 20220401 INTL 0
> XSDT 000e45e0 44 v01 U-BOOT U-BOOTBL 20220401 INTL 0
> CSRT 000e53a0 58 v00 U-BOOT U-BOOTBL 20220401 INTL 0
> MCFG 000e5520 3c v01 U-BOOT U-BOOTBL 20220401 INTL 0
> SPCR 000e5560 50 v02 U-BOOT U-BOOTBL 20220401 INTL 0
> APIC 000e55b0 48 v02 U-BOOT U-BOOTBL 20220401 INTL 0
>
> As a result Linux kernel can't find mandatory tables and fails
> to boot.
>
> Hence, revert it for good.
>
> This reverts commit 379d3c1fd6aa490b1ad5697525cfc89b615cf25a.
>
> BugLink: https://lore.kernel.org/all/20220131225930.GJ7515@bill-the-cat/
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-03-31 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:49 [PATCH v1 1/1] Revert "x86: Move FACP table into separate functions" Andy Shevchenko
2022-03-31 13:38 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331133858.GA14476@bill-the-cat \
--to=trini@konsulko.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=fntoth@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot-board-maintainers@lists.denx.de \
--cc=u-boot-custodians@lists.denx.de \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox