From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D19D9C433F5 for ; Thu, 31 Mar 2022 23:38:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 86733842A2; Fri, 1 Apr 2022 01:31:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 321D4820F5; Fri, 1 Apr 2022 01:31:22 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id C3590842C3 for ; Fri, 1 Apr 2022 01:23:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3831113D5; Thu, 31 Mar 2022 16:23:10 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E93053F73B; Thu, 31 Mar 2022 16:23:08 -0700 (PDT) Date: Fri, 1 Apr 2022 00:19:45 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Sean Anderson , Simon Glass , Heinrich Schuchardt , Heiko Schocher , Joe Hershberger Subject: Re: [PATCH v2 09/23] pinctrl: sunxi: Add sunxi GMAC pinmuxes Message-ID: <20220401001945.72fdd860@slackpad.lan> In-Reply-To: <20220318035420.15058-10-samuel@sholland.org> References: <20220318035420.15058-1-samuel@sholland.org> <20220318035420.15058-10-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 17 Mar 2022 22:54:06 -0500 Samuel Holland wrote: > Pin lists and mux values were taken from the Linux drivers. > > Signed-off-by: Samuel Holland Compared against the respective manuals. Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > index 2525a91e35..7540e7668a 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > @@ -277,6 +277,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun5i_a13_pinctrl_desc = { > }; > > static const struct sunxi_pinctrl_function sun6i_a31_pinctrl_functions[] = { > + { "gmac", 2 }, /* PA0-PA27 */ > { "gpio_in", 0 }, > { "gpio_out", 1 }, > #if IS_ENABLED(CONFIG_UART0_PORT_F) > @@ -308,6 +309,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun6i_a31_r_pinctrl_desc = > > static const struct sunxi_pinctrl_function sun7i_a20_pinctrl_functions[] = { > { "emac", 2 }, /* PA0-PA17 */ > + { "gmac", 5 }, /* PA0-PA17 */ > { "gpio_in", 0 }, > { "gpio_out", 1 }, > #if IS_ENABLED(CONFIG_UART0_PORT_F) > @@ -457,6 +459,7 @@ static const struct sunxi_pinctrl_desc __maybe_unused sun8i_v3s_pinctrl_desc = { > }; > > static const struct sunxi_pinctrl_function sun9i_a80_pinctrl_functions[] = { > + { "gmac", 2 }, /* PA0-PA17 */ > { "gpio_in", 0 }, > { "gpio_out", 1 }, > #if IS_ENABLED(CONFIG_UART0_PORT_F)