Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot

Andre Przywara
2022-03-31T23:28:08Z

On Thu, 17 Mar 2022 22:54:12 -0500
Samuel Holland <samuel@sholland.org> wrote:

> This is now handled automatically by the clock and pinctrl drivers.
>
> SPL still calls this function because it needes the non-DM code.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Looks good, but needs some testing to see if really cover all the
clocks already.

Anyway:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>
> (no changes since v1)
>
> board/sunxi/board.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index 05249d47eb..77ceefdb46 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -241,14 +241,6 @@ int board_init(void)
> }
> }
>
> -#if CONFIG_IS_ENABLED(DM_I2C)
> - /*
> - * Temporary workaround for enabling I2C clocks until proper sunxi DM
> - * clk, reset and pinctrl drivers land.
> - */
> - i2c_init_board();
> -#endif
> -
> #ifdef CONFIG_DM_MMC
> /*
> * Temporary workaround for enabling MMC clocks until a sunxi DM