Re: [PATCH v2 22/23] pinctrl: sunxi: Add SPI0 pinmuxes

Andre Przywara
2022-03-31T23:34:08Z

On Thu, 17 Mar 2022 22:54:19 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Pin lists and mux values were taken from the Linux drivers.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Compared against the respective manuals:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>
> (no changes since v1)
>
> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index dc52de0cf1..932aa6e2d8 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -229,6 +229,7 @@ static const struct sunxi_pinctrl_function suniv_f1c100s_pinctrl_functions[] = {
> { "i2c1", 3 }, /* PD5-PD6 */
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 3 }, /* PC0-PC2 */
> + { "spi0", 2 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -257,6 +258,7 @@ static const struct sunxi_pinctrl_function sun4i_a10_pinctrl_functions[] = {
> #endif
> { "mmc2", 3 }, /* PC6-PC15 */
> { "mmc3", 2 }, /* PI4-PI9 */
> + { "spi0", 3 }, /* PC0-PC2, PC23 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 4 }, /* PF2-PF4 */
> #else
> @@ -280,6 +282,7 @@ static const struct sunxi_pinctrl_function sun5i_a13_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG3-PG8 */
> { "mmc2", 3 }, /* PC6-PC15 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 4 }, /* PF2-PF4 */
> #else
> @@ -305,6 +308,7 @@ static const struct sunxi_pinctrl_function sun6i_a31_pinctrl_functions[] = {
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC6-PC15, PC24 */
> { "mmc3", 4 }, /* PC6-PC15, PC24 */
> + { "spi0", 3 }, /* PC0-PC2, PC27 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -347,6 +351,7 @@ static const struct sunxi_pinctrl_function sun7i_a20_pinctrl_functions[] = {
> { "mmc1", 4 }, /* PG0-PG5 */
> #endif
> { "mmc2", 3 }, /* PC5-PC15, PC24 */
> + { "spi0", 3 }, /* PC0-PC2, PC23 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 4 }, /* PF2-PF4 */
> #else
> @@ -369,6 +374,7 @@ static const struct sunxi_pinctrl_function sun8i_a23_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC5-PC16 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #endif
> @@ -405,6 +411,7 @@ static const struct sunxi_pinctrl_function sun8i_a33_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC5-PC16 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -430,6 +437,7 @@ static const struct sunxi_pinctrl_function sun8i_a83t_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC5-PC16 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -469,6 +477,7 @@ static const struct sunxi_pinctrl_function sun8i_h3_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC5-PC16 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -508,6 +517,7 @@ static const struct sunxi_pinctrl_function sun8i_v3s_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 2 }, /* PC0-PC10 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -533,6 +543,7 @@ static const struct sunxi_pinctrl_function sun9i_a80_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC6-PC16 */
> + { "spi0", 3 }, /* PC0-PC2, PC19 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 4 }, /* PF2-PF4 */
> #else
> @@ -572,6 +583,7 @@ static const struct sunxi_pinctrl_function sun50i_a64_pinctrl_functions[] = {
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC1-PC16 */
> { "pwm", 2 }, /* PD22 */
> + { "spi0", 4 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -611,6 +623,7 @@ static const struct sunxi_pinctrl_function sun50i_h5_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC1-PC16 */
> + { "spi0", 3 }, /* PC0-PC3 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -636,6 +649,7 @@ static const struct sunxi_pinctrl_function sun50i_h6_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC1-PC14 */
> + { "spi0", 4 }, /* PC0-PC7 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else
> @@ -672,6 +686,7 @@ static const struct sunxi_pinctrl_function sun50i_h616_pinctrl_functions[] = {
> { "mmc0", 2 }, /* PF0-PF5 */
> { "mmc1", 2 }, /* PG0-PG5 */
> { "mmc2", 3 }, /* PC0-PC16 */
> + { "spi0", 4 }, /* PC0-PC7, PC15-PC16 */
> #if IS_ENABLED(CONFIG_UART0_PORT_F)
> { "uart0", 3 }, /* PF2-PF4 */
> #else