From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06BEFC433EF for ; Thu, 31 Mar 2022 23:28:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DCD8842AD; Fri, 1 Apr 2022 01:23:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 23DAC8429D; Fri, 1 Apr 2022 01:23:04 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id CFFD58429D for ; Fri, 1 Apr 2022 01:22:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE57015BF; Thu, 31 Mar 2022 16:22:44 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AFDD3F73B; Thu, 31 Mar 2022 16:22:43 -0700 (PDT) Date: Fri, 1 Apr 2022 00:20:32 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Sean Anderson , Simon Glass , Heinrich Schuchardt , Heiko Schocher , Joe Hershberger Subject: Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot Message-ID: <20220401002032.3224fcac@slackpad.lan> In-Reply-To: <20220318035420.15058-16-samuel@sholland.org> References: <20220318035420.15058-1-samuel@sholland.org> <20220318035420.15058-16-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 17 Mar 2022 22:54:12 -0500 Samuel Holland wrote: > This is now handled automatically by the clock and pinctrl drivers. > > SPL still calls this function because it needes the non-DM code. > > Signed-off-by: Samuel Holland Looks good, but needs some testing to see if really cover all the clocks already. Anyway: Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > board/sunxi/board.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index 05249d47eb..77ceefdb46 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -241,14 +241,6 @@ int board_init(void) > } > } > > -#if CONFIG_IS_ENABLED(DM_I2C) > - /* > - * Temporary workaround for enabling I2C clocks until proper sunxi DM > - * clk, reset and pinctrl drivers land. > - */ > - i2c_init_board(); > -#endif > - > #ifdef CONFIG_DM_MMC > /* > * Temporary workaround for enabling MMC clocks until a sunxi DM