From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91940C433F5 for ; Thu, 31 Mar 2022 23:32:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E4AD3842EA; Fri, 1 Apr 2022 01:25:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2D3BB842D3; Fri, 1 Apr 2022 01:23:23 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id D28E8842B2 for ; Fri, 1 Apr 2022 01:22:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE71313D5; Thu, 31 Mar 2022 16:22:49 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B25BC3F73B; Thu, 31 Mar 2022 16:22:48 -0700 (PDT) Date: Fri, 1 Apr 2022 00:21:16 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Sean Anderson , Simon Glass , Heinrich Schuchardt , Heiko Schocher , Joe Hershberger Subject: Re: [PATCH v2 21/23] pwm: sunxi: Remove non-DM pin setup Message-ID: <20220401002116.364b0343@slackpad.lan> In-Reply-To: <20220318035420.15058-22-samuel@sholland.org> References: <20220318035420.15058-1-samuel@sholland.org> <20220318035420.15058-22-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 17 Mar 2022 22:54:18 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 - > drivers/pwm/sunxi_pwm.c | 11 ----------- > 2 files changed, 12 deletions(-) > > diff --git a/arch/arm/include/asm/arch-sunxi/gpio.h b/arch/arm/include/asm/arch-sunxi/gpio.h > index cf5afdac6a..9f07d907e5 100644 > --- a/arch/arm/include/asm/arch-sunxi/gpio.h > +++ b/arch/arm/include/asm/arch-sunxi/gpio.h > @@ -159,7 +159,6 @@ enum sunxi_gpio_number { > > #define SUNXI_GPD_LCD0 2 > #define SUNXI_GPD_LVDS0 3 > -#define SUNXI_GPD_PWM 2 > > #define SUNIV_GPE_UART0 5 > > diff --git a/drivers/pwm/sunxi_pwm.c b/drivers/pwm/sunxi_pwm.c > index e3d5ee456b..bb1bec05ec 100644 > --- a/drivers/pwm/sunxi_pwm.c > +++ b/drivers/pwm/sunxi_pwm.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > > DECLARE_GLOBAL_DATA_PTR; > @@ -45,14 +44,6 @@ static const u32 prescaler_table[] = { > 1, /* 1111 */ > }; > > -static int sunxi_pwm_config_pinmux(void) > -{ > -#ifdef CONFIG_MACH_SUN50I > - sunxi_gpio_set_cfgpin(SUNXI_GPD(22), SUNXI_GPD_PWM); > -#endif > - return 0; > -} > - > static int sunxi_pwm_set_invert(struct udevice *dev, uint channel, > bool polarity) > { > @@ -137,8 +128,6 @@ static int sunxi_pwm_set_enable(struct udevice *dev, uint channel, bool enable) > return 0; > } > > - sunxi_pwm_config_pinmux(); > - > if (priv->invert) > v &= ~SUNXI_PWM_CTRL_CH0_ACT_STA; > else