Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot

Samuel Holland
2022-04-01T00:05:21Z

On 3/31/22 6:20 PM, Andre Przywara wrote:
> On Thu, 17 Mar 2022 22:54:12 -0500
> Samuel Holland <samuel@sholland.org> wrote:
>
>> This is now handled automatically by the clock and pinctrl drivers.
>>
>> SPL still calls this function because it needes the non-DM code.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Looks good, but needs some testing to see if really cover all the
> clocks already.

This is a good point. A31 and A23/A33 are still using the legacy PRCM MFD/clocks
binding, so we will need drivers for those before we can merge this (and the
P2WI/RSB patches).

Regards,
Samuel

> Anyway:
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>
> Cheers,
> Andre
>
>> ---
>>
>> (no changes since v1)
>>
>> board/sunxi/board.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
>> index 05249d47eb..77ceefdb46 100644
>> --- a/board/sunxi/board.c
>> +++ b/board/sunxi/board.c
>> @@ -241,14 +241,6 @@ int board_init(void)
>> }
>> }
>>
>> -#if CONFIG_IS_ENABLED(DM_I2C)
>> - /*
>> - * Temporary workaround for enabling I2C clocks until proper sunxi DM
>> - * clk, reset and pinctrl drivers land.
>> - */
>> - i2c_init_board();
>> -#endif
>> -
>> #ifdef CONFIG_DM_MMC
>> /*
>> * Temporary workaround for enabling MMC clocks until a sunxi DM
>