From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6FF3C433F5 for ; Fri, 1 Apr 2022 01:27:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 84FDE842B1; Fri, 1 Apr 2022 03:26:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="StM44nHF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03DE284215; Fri, 1 Apr 2022 03:26:40 +0200 (CEST) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4E8708410D for ; Fri, 1 Apr 2022 03:19:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id jo24so959146qvb.5 for ; Thu, 31 Mar 2022 18:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rN+O6o8YBcQ5qXVLlmkI85abcNmuWgQCepDtoXaCEhU=; b=StM44nHF+kHtyWcElkf5rL6gxRK2XYSKvEVbz0HWL1xpB43XJX7LzcdUp7wweIMMsS MlyovC7zxYbtgPjyeUIL8DdMl6RTLDtreJ26IoWs4d+zSahhFGLIQ1IWOA93sxHHTF+H FidLjNt60gdQr/uco6TpUBXzGER0MovNmJSaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rN+O6o8YBcQ5qXVLlmkI85abcNmuWgQCepDtoXaCEhU=; b=qDG0zBK38XhW+BZO1QQmMTXyyRxW2r+YeN/SSwXwGJdHF4YcYlFHl+CyUtXWVIe3H0 fJdQp7GxHc0Dbj+QkVBBT1wG6ePtIdmWZlnvdprnUDTthNjRku9zsYGGkPJlFg4bHeUX P21uPLIUmYXXHv5EQtfFxuZfhBWav1hJg6OgpiegInTDnPCt6rLrrXVQr4FLJc7UX9Q/ BZO9wV/uNx0DbBm2zhh4hEBeF+z5Z1YylnrYE3mtZc/L0lGtrk4/SLzfoHzXyHUES/D4 N21uPFk7sI4R+ccBSbiDj7Df0LWMfUcfcDOGnIw4hJWc7mhOO1HNrFOm+brcyiKiQ2UE zqXg== X-Gm-Message-State: AOAM533gmQ6mN3wgA6d3uxm+KRL4R5F/jjdx+YvkhebJMLO4/U6pjNl4 CD8j3vYNrR8H2010eHajYRGw4A== X-Google-Smtp-Source: ABdhPJyc83z7nqTdw6uFPnoDDfp4Y+I8ZRqagmP+vJWBUXJD04IyEZK3AkeENECrJc+pL37JlBPeQA== X-Received: by 2002:ad4:5cc7:0:b0:441:17cc:9a4f with SMTP id iu7-20020ad45cc7000000b0044117cc9a4fmr6413766qvb.29.1648775949914; Thu, 31 Mar 2022 18:19:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f34-20020a05622a1a2200b002e1a35ed1desm871758qtb.94.2022.03.31.18.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 18:19:08 -0700 (PDT) Date: Thu, 31 Mar 2022 21:19:06 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Sean Anderson , Joe Hershberger , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH] env: Avoid using a leftover text-environment file Message-ID: <20220401011906.GA3098353@bill-the-cat> References: <20220312053723.517229-1-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: <20220312053723.517229-1-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 11, 2022 at 10:37:23PM -0700, Simon Glass wrote: > If include/generated/environment.h exists (perhaps leftover from a build > of another board) it is used, even if the board currently being built does > not have a text environment. >=20 > This causes a build error. Fix it by emptying the file if it should not be > there. >=20 > Fixes: https://source.denx.de/u-boot/u-boot/-/issues/9 > Signed-off-by: Simon Glass > Reported-by: Sean Anderson > Tested-by: Sean Anderson Applied to u-boot/master, thanks! --=20 Tom --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJGUwEACgkQFHw5/5Y0 tyyK0gv/eEybCS2xyEjcGQtImnD2WUj7Ybs6zL0Ik8tHsOKBAtzJB7wYJnROglEm rNo1ytoD7CzyiWWhbgM6prxC+lzjGFf99jtF2gTn40EzXojqQX5rJ1c6xblKu50R XyNQok8E8qZRQnsQ4eFLW4CrnGBTpzGvSvxEPl5LC8ltUeMhtrPXgCXNQHbW+Iyj Bz+dqdbZN4+pF33jNYxy32wwpYp5mhRrQsWsL4709a3XdIzPx2qCfieoUP8CLreZ maLQyyQP91LKV3X79PclfV3qPmIdU/kRUyEdKQ1bFmsIqwPPKxMue3JB4DBe94j6 9qleisjKsZXzTuMKkPKq5TQacLhMnlXAUWZ3Nt9NWMRWrLrPdhqxdzVfPmiiQrah KXDd4yugyybXoXkmnTj8scPbcrHf++YDq2Ps7qxnPHTallZ2+v82MoD8NU71IguG KFcD6paODQ5eW1+1iZVD7iRL+7MZZkn7jyzWWDEuouhxKIGP1S2py4HvIxthuHfH hNAIm7A/ =cDmx -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm--