From: "Paweł Anikiel" <pan@semihalf.com>
To: marex@denx.de, simon.k.r.goldschmidt@gmail.com,
tien.fong.chee@intel.com, michal.simek@xilinx.com
Cc: u-boot@lists.denx.de, sjg@chromium.org, festevam@denx.de,
jagan@amarulasolutions.com, andre.przywara@arm.com,
narmstrong@baylibre.com, pbrobinson@gmail.com,
tharvey@gateworks.com, paul.liu@linaro.org,
christianshewitt@gmail.com, adrian.fiergolski@fastree3d.com,
marek.behun@nic.cz, wd@denx.de, elly.siew.chin.lim@intel.com,
mw@semihalf.com, "Paweł Anikiel" <pan@semihalf.com>
Subject: [PATCH 10/11] socfpga: arria10: Wait for fifo empty after writing bitstream
Date: Fri, 1 Apr 2022 14:43:24 +0200 [thread overview]
Message-ID: <20220401124325.1810108-11-pan@semihalf.com> (raw)
In-Reply-To: <20220401124325.1810108-1-pan@semihalf.com>
For some reason, on the Mercury+ AA1 module, calling
fpgamgr_wait_early_user_mode immediately after writing the peripheral
bitstream leaves the fpga in a broken state (ddr calibration hangs).
Adding a delay before the first sync word is written seems to fix this.
Inspecting the fpgamgr registers before and after the delay,
imgcfg_FifoEmpty is the only bit that changes. Waiting for this bit
(instead of a hardcoded delay) also fixes the issue.
Signed-off-by: Paweł Anikiel <pan@semihalf.com>
---
drivers/fpga/socfpga_arria10.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/fpga/socfpga_arria10.c b/drivers/fpga/socfpga_arria10.c
index 07bfe3060e..d8089122af 100644
--- a/drivers/fpga/socfpga_arria10.c
+++ b/drivers/fpga/socfpga_arria10.c
@@ -80,6 +80,13 @@ static int wait_for_user_mode(void)
1, FPGA_TIMEOUT_MSEC, false);
}
+static int wait_for_fifo_empty(void)
+{
+ return wait_for_bit_le32(&fpga_manager_base->imgcfg_stat,
+ ALT_FPGAMGR_IMGCFG_STAT_F2S_IMGCFG_FIFOEMPTY_SET_MSK,
+ 1, FPGA_TIMEOUT_MSEC, false);
+}
+
int is_fpgamgr_early_user_mode(void)
{
return (readl(&fpga_manager_base->imgcfg_stat) &
@@ -874,6 +881,7 @@ int socfpga_loadfs(fpga_fs_info *fpga_fsinfo, const void *buf, size_t bsize,
WATCHDOG_RESET();
}
+ wait_for_fifo_empty();
if (fpga_loadfs.rbfinfo.section == periph_section) {
if (fpgamgr_wait_early_user_mode() != -ETIMEDOUT) {
--
2.35.1.1094.g7c7d902a7c-goog
next prev parent reply other threads:[~2022-04-01 13:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 12:43 [PATCH 00/11] Add Chameleon V3 support Paweł Anikiel
2022-04-01 12:43 ` [PATCH 01/11] arm: dts: Add Mercury+ AA1 devicetree Paweł Anikiel
2022-04-11 18:34 ` Simon Glass
2022-04-14 14:07 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 02/11] arm: dts: Add Chameleonv3 handoff headers Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 13:58 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 03/11] arm: dts: Add Chameleonv3 devicetree Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 15:57 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 04/11] board: Add Chameleonv3 board dir Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 05/11] config: Add Chameleonv3 config Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 06/11] misc: atsha204a: Increase wake delay by tWHI Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 07/11] sysreset: socfpga: Use parent device for reading base address Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-14 13:33 ` Paweł Anikiel
2022-04-01 12:43 ` [PATCH 08/11] socfpga: arria10: Replace delays with busy waiting in cm_full_cfg Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` [PATCH 09/11] socfpga: arria10: Improve bitstream loading speed Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
2022-04-01 12:43 ` Paweł Anikiel [this message]
2022-04-11 18:35 ` [PATCH 10/11] socfpga: arria10: Wait for fifo empty after writing bitstream Simon Glass
2022-04-01 12:43 ` [PATCH 11/11] socfpga: arria10: Allow dcache_enable before relocation Paweł Anikiel
2022-04-11 18:35 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401124325.1810108-11-pan@semihalf.com \
--to=pan@semihalf.com \
--cc=adrian.fiergolski@fastree3d.com \
--cc=andre.przywara@arm.com \
--cc=christianshewitt@gmail.com \
--cc=elly.siew.chin.lim@intel.com \
--cc=festevam@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=michal.simek@xilinx.com \
--cc=mw@semihalf.com \
--cc=narmstrong@baylibre.com \
--cc=paul.liu@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox